search

TrevorBarns / luxart-vehicle-control

A siren / (non-els) emergency lights controller for FiveM.
https://www.luxartengineering.com/
GNU General Public License v3.0
135 stars 56 forks source link

Labeling in main siren settings menu not ordered correctly. #8

Closed Salzian closed 3 years ago

Salzian commented 4 years ago

In VEHICLES.lua I added a custom car like this:

car = { 1, 7, 10, 4 }

My intention is to have the cycle in the order of 7, 10, 4. Using R to cycle those does work as expected and retains the order.

Now have a look at this list.

2020-10-04 17_28_11-FiveM - Salzian Local Dev

The labels are instead ordered by the corresponding number of the sound.

Priority = 4 BikeWail = 7 BikeYelp = 10

While this may be confusing on it's own, the real problem is, that the settings on the right (Cycle & Button) does not follow this ordering. To set the Priority sound to e.g. "Cycle only", you need to set BikeYelp at the bottom.

TrevorBarns commented 3 years ago

This behavior is not currently supported, LVC was designed with tone IDs being in numerical order. The reason being is if you wanted to change the siren tone order, you could change the tone wav files in the RESIDENT.RPF.

I understand that changing those files can be rather tedious so I have changed this from bug to enhancement. Currently looking into this.

TrevorBarns commented 3 years ago

Fixed as of version 3.1.5-beta. https://github.com/TrevorBarns/luxart-vehicle-control/releases/tag/3.1.5