search

TrevorEdwards / bigredapp-android

Informational Android app for Cornell University.
https://play.google.com/store/apps/details?id=is.genki.bigredapp.android&hl=en
MIT License
14 stars 8 forks source link

Menu Formatting, Dining Hall Sorting #39

Closed TrevorEdwards closed 9 years ago

TrevorEdwards commented 9 years ago

Menus now have a well-formatted title and menu items are listed per line rather than separated by commas.

Dining halls are automatically sorted by open status, and the views now have a field for name of dining hall so that they can be properly selected.

ghost commented 9 years ago

Ah awesome thank you so much for doing this! :+1: I'll check this out and go through the diffs soon, hopefully sometime this week, definitely by end of next weekend.

ghost commented 9 years ago

Updating here: after some offline discussions, initial review will wait until some other issues are resolved.

ghost commented 9 years ago

Okay, I'm gonna kick this off with just a preliminary code review. This will be just whatever is on my mind as I'm reading through them. Would love to hear when your opinions differ about a comment of mine of course :). After this review, we'll discuss about how to go from here and get these diffs, along with any changes we make, into master. :+1:

During the review, I will talk about things that should go in its own commit. We will end up taking the changes done here and split them into functionally independent commits, that each accomplish one easy-to-summarize goal.

ghost commented 9 years ago

Okay so if I had to summarize that first commit, I would say it has three parts: 1) Making it so the currently-open things are at the top. 2) Beautify the menus/names. This involves first pulling out formatDiningHallName. 3) Style changes. (As noted in chat elsewhere, looks like this was done by Android Studio. So, we will accept its formatting desires because they make sense too).

ghost commented 9 years ago

Okay, done with the first pass through. As always, open to input/counter points/reactions/etc. from anyone of course.

ghost commented 9 years ago

[Note for history: worked with Trevor in person to resolve the above]. Great, thank you again, merged with c0fdfb564bf4dd18a4d440d51462da03c2f0ae43.