search

TrevorEdwards / bigredapp-android

Informational Android app for Cornell University.
https://play.google.com/store/apps/details?id=is.genki.bigredapp.android&hl=en
MIT License
14 stars 8 forks source link

Added people search #51

Closed hanli1 closed 8 years ago

hanli1 commented 8 years ago

People search added to find people with netids

TrevorEdwards commented 8 years ago

Okay this looks almost ready, just needs a few (hopefully) minor fixes:

  1. Long names don't appear to be supported well. For example my full name causes my netid to bleed down the side of the card. I think you should at least put the netid on its own line for a starting fix.
  2. The new navigation drawer looks nice, but the old one highlighted in red and it would be nice to keep that theme, so could you change the color of the highlighting?
    • Also on this, I'm not sure if you have it, but when I select a new tab on the navigation drawer, random other tabs get highlighted briefly. Maybe a for loop is selecting things strangely, not sure. See if you notice that.

Feel free to discuss any of these.

hanli1 commented 8 years ago
TrevorEdwards commented 8 years ago

Looks great, thanks!