search

TrevorS / bootstrap3-datetimepicker-rails

This gem packages the bootstrap-datetimepicker for the Rails 3.1+ asset pipeline.
MIT License
292 stars 123 forks source link

datepicker updates #15

Closed Eonasdan closed 10 years ago

Eonasdan commented 10 years ago

Hi @TrevorS we've released 3.0.2 to be compatible with moment 2.8.1 and fix some other issues.

TrevorS commented 10 years ago

Excellent, I'll get on bringing them gem up to date.

TrevorS commented 10 years ago

@Eonasdan, does bootstrap-datetimepciker 3.0.2 require Momentjs 2.8.x or higher?

The maintainer of the Momentjs Rails gem I am using has not updated to 2.8 yet.

I'm getting a JS error: Uncaught TypeError: undefined is not a function

@ Line 86:

pMoment.locale(picker.options.language);

Or is possibly a different issue? Do I need to include any locales if I'm going to use English/American?

Eonasdan commented 10 years ago

yes it does. 2.8.1 changed lang to locale. I'd suggest trying to get the moment rails person to update it

TrevorS commented 10 years ago

I submitted an issue a couple hours ago:

https://github.com/derekprior/momentjs-rails/issues/25

njvitto commented 10 years ago

Hi @TrevorS, I have exactly the same issue. Do you have a quick fix to solve it in the meanwhile?

Thx a lot!

TrevorS commented 10 years ago

Sorry, the only option I can think of is to create my own copy of the gem and update it myself, but I don't want fragment the Ruby/Rails ecosystem. :|

Eonasdan commented 10 years ago

until they update the moment gem, just manually update the momentjs file or update this gem to include the moment js file until it's updated.

TrevorS commented 10 years ago

@Eonasdan, @njvitto -- the Moment.js gem has been updated and I've performed a new release of bootstrap3-datetimepicker-rails.

njvitto commented 10 years ago

Thx a lot for the quick support @TrevorS :+1: