search

TrevorS / bootstrap3-datetimepicker-rails

This gem packages the bootstrap-datetimepicker for the Rails 3.1+ asset pipeline.
MIT License
292 stars 123 forks source link

How to fix browser crashing in October? #5

Closed ricardodovalle closed 10 years ago

ricardodovalle commented 10 years ago

There is a bug in bootstrap-datetimepicker, the browser crash in October, maybe it is because the daylight saving time.

Anyone know a way to fix it?

Thanks.

source: https://github.com/Eonasdan/bootstrap-datetimepicker/issues/297

TrevorS commented 10 years ago

Yeah, I've seen that issue in the main repository. Hopefully this Eonasdan/bootstrap-datetimepicker#282 will fix it and get accepted into the repo.

TrevorS commented 10 years ago

Should be fixed by: 35e282aa6d2e216a1702fc8b1ce3f926f18af342.

zerocool4u2 commented 10 years ago

Hi, still having this issue but in September(lol), any ideas or some guidance for fixing it? Local time utc-3, regards

diegocouto commented 10 years ago

Unfortunately, this problem is still around. Probably it's only a curiosity, but as @zerocool4u2, I'm also using UTC-3 as the base timezone.

zerocool4u2 commented 10 years ago

i give it a couples of days, but not luck solving this, so i move to this one http://xdsoft.net/jqplugins/datetimepicker/ , i didn't find it as a gem, but doesn't have any integration problems with simple import and works pretty similar, remove font-family from css for getting a more bootstrap like appearance

diegocouto commented 10 years ago

Awesome suggestion, @zerocool4u2. I'm definitely going to give it a try. Thanks!

TrevorS commented 10 years ago

Sorry I haven't had a chance to really look at this issue. Have you tried since the new release?

zerocool4u2 commented 10 years ago

Hi, don't worry, yup i tried with the last release, but to be honest i don't know when the bug starts, i was using this gem for 3 or 4 months and just see it a couple of weeks ago since we went closer to the date when the bug appears, i tried to force to use other versions of momentjs and oldest versions of the gem, but the bug persists, i guest it was a momentjs bug actually, but couldn't find it, when tried to debug it the error jumps between lines and couldn't figure it out how to fix the daytime issue.

henriqueltrindade commented 10 years ago

I'm having the same problem and also occurs in the demo site http://eonasdan.github.io/bootstrap-datetimepicker/

There is an infinite loop in fillDate () method on line 378 in loop code while (prevMonth.isBefore (NextMonth)) ... ... I'm using version gem 'momentjs-rails', '~> 2.5.0' e gem 'bootstrap3-datetimepicker-rails', '~> 3.0.0.2'

How to solve this?