search

TreyRuffy / BetterF3

A Fabric mod ported to Forge for Minecraft that provides a highly customizable, more human-readable Debug HUD.
https://modrinth.com/mod/betterf3
MIT License
26 stars 11 forks source link

[Bug]: 24w14a Crashes #75

Closed lowercasebtw closed 4 months ago

lowercasebtw commented 5 months ago

Describe the Bug

In 24w14a, if you press F3 the game crashes with this error

[01:56:43] [Render thread/ERROR]: Unreported exception thrown!
java.lang.NoSuchMethodError: 'boolean net.minecraft.client.MinecraftClient.method_1540()'
    at me.cominixo.betterf3.modules.SystemModule.update(SystemModule.java:98) ~[BetterF3-10.0.0-alpha.1-Fabric-24w12a.jar:?]
    at me.cominixo.betterf3.utils.DebugRenderer.newText(DebugRenderer.java:218) ~[BetterF3-10.0.0-alpha.1-Fabric-24w12a.jar:?]

Steps to Reproduce

Open 24w14a Press F3 Crash

Expected Behavior

Display BetterF3 Menu

Screenshots

image image

Modloader Type

Fabric

Modloader Version

0.15.9

Mod Version

10.0.0-alpha.1

Log Output

[01:56:43] [Render thread/ERROR]: Unreported exception thrown!
java.lang.NoSuchMethodError: 'boolean net.minecraft.client.MinecraftClient.method_1540()'
    at me.cominixo.betterf3.modules.SystemModule.update(SystemModule.java:98) ~[BetterF3-10.0.0-alpha.1-Fabric-24w12a.jar:?]
    at me.cominixo.betterf3.utils.DebugRenderer.newText(DebugRenderer.java:218) ~[BetterF3-10.0.0-alpha.1-Fabric-24w12a.jar:?]
    at MC/net.minecraft.client.gui.hud.DebugHud.handler$zzj000$betterf3$drawRightText(DebugHud.java:1725) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.gui.hud.DebugHud.drawRightText(DebugHud.java) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.gui.hud.DebugHud.method_51746(DebugHud.java:141) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.gui.DrawContext.draw(DrawContext.java:91) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.gui.hud.DebugHud.render(DebugHud.java:139) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.gui.hud.InGameHud.method_55807(InGameHud.java:190) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.gui.LayeredDrawer.renderInternal(LayeredDrawer.java:34) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.gui.LayeredDrawer.method_55812(LayeredDrawer.java:20) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.gui.LayeredDrawer.renderInternal(LayeredDrawer.java:34) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.gui.LayeredDrawer.render(LayeredDrawer.java:27) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.gui.hud.InGameHud.render(InGameHud.java:217) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.render.GameRenderer.render(GameRenderer.java:901) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.MinecraftClient.render(MinecraftClient.java:1322) ~[client-intermediary.jar:?]
    at MC/net.minecraft.client.MinecraftClient.run(MinecraftClient.java:890) [client-intermediary.jar:?]
    at net.minecraft.client.main.Main.main(Main.java:265) [client-intermediary.jar:?]
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) [fabric-loader-0.15.9.jar:?]
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.15.9.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.15.9.jar:?]
    at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) [NewLaunch.jar:?]
    at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129) [NewLaunch.jar:?]
    at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) [NewLaunch.jar:?]
[01:56:43] [Render thread/INFO]: [voicechat] Clearing audio channels
---- Minecraft Crash Report ----
// Hey, that tickles! Hehehe!

Time: 2024-04-07 01:56:43
Description: Unexpected error

java.lang.NoSuchMethodError: 'boolean net.minecraft.client.MinecraftClient.method_1540()'
    at me.cominixo.betterf3.modules.SystemModule.update(SystemModule.java:98)
    at me.cominixo.betterf3.utils.DebugRenderer.newText(DebugRenderer.java:218)
    at MC//net.minecraft.client.gui.hud.DebugHud.handler$zzj000$betterf3$drawRightText(DebugHud.java:1725)
    at MC//net.minecraft.client.gui.hud.DebugHud.drawRightText(DebugHud.java)
    at MC//net.minecraft.client.gui.hud.DebugHud.method_51746(DebugHud.java:141)
    at MC//net.minecraft.client.gui.DrawContext.draw(DrawContext.java:91)
    at MC//net.minecraft.client.gui.hud.DebugHud.render(DebugHud.java:139)
    at MC//net.minecraft.client.gui.hud.InGameHud.method_55807(InGameHud.java:190)
    at MC//net.minecraft.client.gui.LayeredDrawer.renderInternal(LayeredDrawer.java:34)
    at MC//net.minecraft.client.gui.LayeredDrawer.method_55812(LayeredDrawer.java:20)
    at MC//net.minecraft.client.gui.LayeredDrawer.renderInternal(LayeredDrawer.java:34)
    at MC//net.minecraft.client.gui.LayeredDrawer.render(LayeredDrawer.java:27)
    at MC//net.minecraft.client.gui.hud.InGameHud.render(InGameHud.java:217)
    at MC//net.minecraft.client.render.GameRenderer.render(GameRenderer.java:901)
    at MC//net.minecraft.client.MinecraftClient.render(MinecraftClient.java:1322)
    at MC//net.minecraft.client.MinecraftClient.run(MinecraftClient.java:890)
    at net.minecraft.client.main.Main.main(Main.java:265)
    at app//net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
    at app//net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
    at app//net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
    at app//org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87)
    at app//org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
    at app//org.prismlauncher.EntryPoint.main(EntryPoint.java:70)

A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
    at me.cominixo.betterf3.modules.SystemModule.update(SystemModule.java:98)
    at me.cominixo.betterf3.utils.DebugRenderer.newText(DebugRenderer.java:218)
    at MC//net.minecraft.client.gui.hud.DebugHud.handler$zzj000$betterf3$drawRightText(DebugHud.java:1725)
    at MC//net.minecraft.client.gui.hud.DebugHud.drawRightText(DebugHud.java)
    at MC//net.minecraft.client.gui.hud.DebugHud.method_51746(DebugHud.java:141)
    at MC//net.minecraft.client.gui.DrawContext.draw(DrawContext.java:91)
    at MC//net.minecraft.client.gui.hud.DebugHud.render(DebugHud.java:139)
    at MC//net.minecraft.client.gui.hud.InGameHud.method_55807(InGameHud.java:190)
    at MC//net.minecraft.client.gui.LayeredDrawer.renderInternal(LayeredDrawer.java:34)
    at MC//net.minecraft.client.gui.LayeredDrawer.method_55812(LayeredDrawer.java:20)
    at MC//net.minecraft.client.gui.LayeredDrawer.renderInternal(LayeredDrawer.java:34)
    at MC//net.minecraft.client.gui.LayeredDrawer.render(LayeredDrawer.java:27)
    at MC//net.minecraft.client.gui.hud.InGameHud.render(InGameHud.java:217)

Additional Context

No response

lowercasebtw commented 5 months ago

no wonder betterf3 crashes in 24w14a its using MinecraftClient.is64bit xD

24w14a+ Is now only 64 bit so Minecraft removed the method/field "is64bit" from the MinecraftClient class

BetaKors commented 4 months ago

this also happens in 1.20.5. was about to make another issue but it would just be a duplicate i believe the fix is prob gonna be to remove all instances of is64bit

lowercasebtw commented 4 months ago

Turns out it’s a bit more, text rendering changed.

On Sat, Apr 27, 2024 at 18:06 BetaKors @.***> wrote:

this also happens in 1.20.5. was about to make another issue but it would just be a duplicate i believe the fix is prob gonna be to remove all instances of is64bit

— Reply to this email directly, view it on GitHub https://github.com/TreyRuffy/BetterF3/issues/75#issuecomment-2081213217, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6E2U4SBLFRNKV4C6UAGJVTY7QOPDAVCNFSM6AAAAABF3BIGVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGIYTGMRRG4 . You are receiving this because you authored the thread.Message ID: @.***>

BetaKors commented 4 months ago

i see. is that why i am getting some FPS drops on the new version (#79)? also, i found a "fix" for this crash: remove all instances of the system module, making its update method not run

TreyRuffy commented 4 months ago

Fixed in 10.0.0