TreyRuffy / BetterF3

A Fabric mod ported to Forge for Minecraft that provides a highly customizable, more human-readable Debug HUD.
https://modrinth.com/mod/betterf3
MIT License
26 stars 11 forks source link

[Bug]: Crash in 1.20.1 - mods incompatibility #76

Open peow opened 5 months ago

peow commented 5 months ago

Describe the Bug

i ask you to accept the Pull Request for 1.20.1 made by the developer from BadOptimizations: https://github.com/TreyRuffy/BetterF3/pull/55

you already accepted the 1.20.2 and 1.20.4 versions, but I need it for 1.20.1 When using the BetterF3 + BadOptimizations mod with the option: enable_fps_string_optimization: true and together with the Kiwi mod/library, when pressing F3 inside the inventory with the mouse cursor above an item, the game crashes image


2024-04-08_10 16 55

Steps to Reproduce

Install latest BetterF3 for Fabric 1.20.1 https://modrinth.com/mod/betterf3/version/7.0.2 Install latest BadOptimizations for Fabric 1.20.1 https://modrinth.com/mod/badoptimizations/version/aKkny43Y Install latest Kiwi for Fabric 1.20.1 https://modrinth.com/mod/kiwi

open the Minecraft and join to a creative world

dont open the F3 debug menu

open the inventory and press F3 above any item

Expected Behavior

BetterF3 + Kiwi: when pressing F3 inside the inventory with mouse cursor above an item, the F3 menu should not open;

BetterF3 + Kiwi + BadOptimizations: when doing the same, it should not crash

Screenshots

Modloader Type

Fabric

Modloader Version

fabric loader 0.15.7 / fabric api 0.92.0

Mod Version

v7.0.2

Log Output

---- Minecraft Crash Report ----
// Daisy, daisy...

Time: 2024-04-08 10:09:28
Description: Unexpected error

java.lang.NumberFormatException: For input string: ""
    at java.base/java.lang.NumberFormatException.forInputString(Unknown Source)
    at java.base/java.lang.Integer.parseInt(Unknown Source)
    at java.base/java.lang.Integer.parseInt(Unknown Source)
    at me.cominixo.betterf3.modules.FpsModule.update(FpsModule.java:65)
    at net.minecraft.class_340.betterF3$newLeftText(class_340.java:1207)
    at net.minecraft.class_340.handler$zba000$betterf3$drawLeftText(class_340.java:1385)
    at net.minecraft.class_340.method_1847(class_340.java)
    at net.minecraft.class_340.method_51746(class_340.java:115)
    at net.minecraft.class_332.method_51741(class_332.java:89)
    at net.minecraft.class_340.method_1846(class_340.java:114)
    at net.minecraft.class_329.method_1753(class_329.java:261)
    at net.minecraft.class_757.method_3192(class_757.java:926)
    at net.minecraft.class_310.method_1523(class_310.java:1219)
    at net.minecraft.class_310.method_1514(class_310.java:802)
    at net.minecraft.client.main.Main.main(Main.java:250)
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
    at java.base/java.lang.NumberFormatException.forInputString(Unknown Source)
    at java.base/java.lang.Integer.parseInt(Unknown Source)
    at java.base/java.lang.Integer.parseInt(Unknown Source)
    at me.cominixo.betterf3.modules.FpsModule.update(FpsModule.java:65)
    at net.minecraft.class_340.betterF3$newLeftText(class_340.java:1207)
    at net.minecraft.class_340.handler$zba000$betterf3$drawLeftText(class_340.java:1385)
    at net.minecraft.class_340.method_1847(class_340.java)
    at net.minecraft.class_340.method_51746(class_340.java:115)
    at net.minecraft.class_332.method_51741(class_332.java:89)
    at net.minecraft.class_340.method_1846(class_340.java:114)
    at net.minecraft.class_329.method_1753(class_329.java:261)

-- Affected level --
Details:
    All players: 1 total; [class_746['zLynkii_'/118, l='ClientLevel', x=205.72, y=72.00, z=78.82]]
    Chunk stats: 841, 533
    Level dimension: minecraft:overworld
    Level spawn location: World: (160,72,-16), Section: (at 0,8,0 in 10,4,-1; chunk contains blocks 160,-64,-16 to 175,319,-1), Region: (0,-1; contains chunks 0,-32 to 31,-1, blocks 0,-64,-512 to 511,319,-1)
    Level time: 178114 game time, 1065 day time
    Server brand: fabric
    Server type: Integrated singleplayer server
Stacktrace:
    at net.minecraft.class_638.method_8538(class_638.java:458)
    at net.minecraft.class_310.method_1587(class_310.java:2406)
    at net.minecraft.class_310.method_1514(class_310.java:826)
    at net.minecraft.client.main.Main.main(Main.java:250)
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

-- Last reload --
Details:
    Reload number: 1
    Reload reason: initial
    Finished: Yes
    Packs: vanilla, fabric, file/FreshAnimations_v1.9.zip

-- System Details --
Details:
    Minecraft Version: 1.20.1
    Minecraft Version ID: 1.20.1
    Operating System: Windows 10 (amd64) version 10.0
    Java Version: 17.0.9, Azul Systems, Inc.
    Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Azul Systems, Inc.
    Memory: 880195584 bytes (839 MiB) / 2415919104 bytes (2304 MiB) up to 8388608000 bytes (8000 MiB)
    CPUs: 12
    Processor Vendor: GenuineIntel
    Processor Name: Intel(R) Core(TM) i5-10400F CPU @ 2.90GHz
    Identifier: Intel64 Family 6 Model 165 Stepping 3
    Microarchitecture: unknown
    Frequency (GHz): 2.90
    Number of physical packages: 1
    Number of physical CPUs: 6
    Number of logical CPUs: 12
    Graphics card #0 name: NVIDIA GeForce GTX 1650
    Graphics card #0 vendor: NVIDIA (0x10de)
    Graphics card #0 VRAM (MB): 4095.00
    Graphics card #0 deviceId: 0x1f0a
    Graphics card #0 versionInfo: DriverVersion=31.0.15.3623
    Memory slot #0 capacity (MB): 16384.00
    Memory slot #0 clockSpeed (GHz): 2.67
    Memory slot #0 type: DDR4
    Memory slot #1 capacity (MB): 8192.00
    Memory slot #1 clockSpeed (GHz): 2.67
    Memory slot #1 type: DDR4
    Virtual memory max (MB): 28070.09
    Virtual memory used (MB): 14551.23
    Swap memory total (MB): 3584.00
    Swap memory used (MB): 168.22
    JVM Flags: 2 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx8000M
    Fabric Mods: 
        badoptimizations: BadOptimizations 2.1.0
        betterf3: BetterF3 7.0.2
        borderlessmining: Borderless Mining 1.1.8+1.20.1
        cateyes: Cat Eyes 7.3.1
        cloth-config: Cloth Config v11 11.1.118
            cloth-basic-math: cloth-basic-math 0.6.1
        entity_model_features: Entity Model Features 1.3
        entity_texture_features: Entity Texture Features 5.2.3
            org_apache_httpcomponents_httpmime: httpmime 4.5.10
        fabric-api: Fabric API 0.92.0+1.20.1
            fabric-api-base: Fabric API Base 0.4.31+1802ada577
            fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.36+1802ada577
            fabric-biome-api-v1: Fabric Biome API (v1) 13.0.13+1802ada577
            fabric-block-api-v1: Fabric Block API (v1) 1.0.11+1802ada577
            fabric-block-view-api-v2: Fabric BlockView API (v2) 1.0.1+1802ada577
            fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.41+1802ada577
            fabric-client-tags-api-v1: Fabric Client Tags 1.1.2+1802ada577
            fabric-command-api-v1: Fabric Command API (v1) 1.2.34+f71b366f77
            fabric-command-api-v2: Fabric Command API (v2) 2.2.13+1802ada577
            fabric-commands-v0: Fabric Commands (v0) 0.2.51+df3654b377
            fabric-containers-v0: Fabric Containers (v0) 0.1.64+df3654b377
            fabric-content-registries-v0: Fabric Content Registries (v0) 4.0.11+1802ada577
            fabric-convention-tags-v1: Fabric Convention Tags 1.5.5+1802ada577
            fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.19+1802ada577
            fabric-data-attachment-api-v1: Fabric Data Attachment API (v1) 1.0.0+de0fd6d177
            fabric-data-generation-api-v1: Fabric Data Generation API (v1) 12.3.4+1802ada577
            fabric-dimensions-v1: Fabric Dimensions API (v1) 2.1.54+1802ada577
            fabric-entity-events-v1: Fabric Entity Events (v1) 1.6.0+1c78457f77
            fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.6.2+1802ada577
            fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.63+df3654b377
            fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.40+1802ada577
            fabric-item-api-v1: Fabric Item API (v1) 2.1.28+1802ada577
            fabric-item-group-api-v1: Fabric Item Group API (v1) 4.0.12+1802ada577
            fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.37+1802ada577
            fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.35+df3654b377
            fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.2.22+1802ada577
            fabric-loot-api-v2: Fabric Loot API (v2) 1.2.1+1802ada577
            fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.1.45+9e7660c677
            fabric-message-api-v1: Fabric Message API (v1) 5.1.9+1802ada577
            fabric-mining-level-api-v1: Fabric Mining Level API (v1) 2.1.50+1802ada577
            fabric-model-loading-api-v1: Fabric Model Loading API (v1) 1.0.3+1802ada577
            fabric-models-v0: Fabric Models (v0) 0.4.2+9386d8a777
            fabric-networking-api-v1: Fabric Networking API (v1) 1.3.11+1802ada577
            fabric-networking-v0: Fabric Networking (v0) 0.3.51+df3654b377
            fabric-object-builder-api-v1: Fabric Object Builder API (v1) 11.1.3+1802ada577
            fabric-particles-v1: Fabric Particles (v1) 1.1.2+1802ada577
            fabric-recipe-api-v1: Fabric Recipe API (v1) 1.0.21+1802ada577
            fabric-registry-sync-v0: Fabric Registry Sync (v0) 2.3.3+1802ada577
            fabric-renderer-api-v1: Fabric Renderer API (v1) 3.2.1+1802ada577
            fabric-renderer-indigo: Fabric Renderer - Indigo 1.5.1+1802ada577
            fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.46+df3654b377
            fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.37+92a0d36777
            fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.0.28+1802ada577
            fabric-rendering-v0: Fabric Rendering (v0) 1.1.49+df3654b377
            fabric-rendering-v1: Fabric Rendering (v1) 3.0.8+1802ada577
            fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 2.3.8+1802ada577
            fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.11.10+1802ada577
            fabric-screen-api-v1: Fabric Screen API (v1) 2.0.8+1802ada577
            fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.3.30+1802ada577
            fabric-sound-api-v1: Fabric Sound API (v1) 1.0.13+1802ada577
            fabric-transfer-api-v1: Fabric Transfer API (v1) 3.3.4+1802ada577
            fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 4.3.1+1802ada577
        fabricloader: Fabric Loader 0.15.7
            mixinextras: MixinExtras 0.3.5
        java: OpenJDK 64-Bit Server VM 17
        kiwi: Kiwi Library 11.6.0
        languagereload: Language Reload 1.5.10+1.20.1
        minecraft: Minecraft 1.20.1
        modmenu: Mod Menu 7.2.2
        sidekick: Sidekick 2.0.5+1.20.1
        yet_another_config_lib_v3: YetAnotherConfigLib 3.2.2+1.20
            com_twelvemonkeys_common_common-image: common-image 3.10.0-SNAPSHOT
            com_twelvemonkeys_common_common-io: common-io 3.10.0-SNAPSHOT
            com_twelvemonkeys_common_common-lang: common-lang 3.10.0-SNAPSHOT
            com_twelvemonkeys_imageio_imageio-core: imageio-core 3.10.0-SNAPSHOT
            com_twelvemonkeys_imageio_imageio-metadata: imageio-metadata 3.10.0-SNAPSHOT
            com_twelvemonkeys_imageio_imageio-webp: imageio-webp 3.10.0-SNAPSHOT
            org_quiltmc_parsers_gson: gson 0.2.1
            org_quiltmc_parsers_json: json 0.2.1
    Launched Version: 1.20.1
    Backend library: LWJGL version 3.3.1 SNAPSHOT
    Backend API: NVIDIA GeForce GTX 1650/PCIe/SSE2 GL version 3.2.0 NVIDIA 536.23, NVIDIA Corporation
    Window size: 1360x705
    GL Caps: Using framebuffer using OpenGL 3.2
    GL debug messages: 
    Using VBOs: Yes
    Is Modded: Definitely; Client brand changed to 'fabric'; Server brand changed to 'fabric'
    Type: Integrated Server (map_client.txt)
    Graphics mode: fancy
    Resource Packs: vanilla, fabric, file/FreshAnimations_v1.9.zip
    Current Language: en_us
    CPU: 12x Intel(R) Core(TM) i5-10400F CPU @ 2.90GHz
    Server Running: true
    Player Count: 1 / 8; [class_3222['zLynkii_'/118, l='ServerLevel[New World]', x=205.72, y=72.00, z=78.82]]
    Data Packs: vanilla, fabric
    Enabled Feature Flags: minecraft:vanilla
    World Generation: Stable

Additional Context

No response