search

TreyWW / MyFinances

MyFinances is a web application that can help you as an individual, or team, manage your finances!
https://docs.myfinances.cloud
GNU Affero General Public License v3.0
104 stars 156 forks source link

bug: Don't load all receipt modals on load, only on click #358

Open TreyWW opened 6 months ago

TreyWW commented 6 months ago

What version of MyFinances are you currently using?

v0.4.0

What device type are you currently facing the issue on?

No response

Describe the bug

At the moment all modals get fetched on load, we should really just be only fetching modal on click like the rest of the app

hussein-mamane commented 3 months ago

hello @TreyWW , I am new to OSS, I am a first-timer, I just setup MyFinances , I am now good to go, give me an image please so I understand the Issue. Thanks a lot.

TreyWW commented 3 months ago

Hey @hussein-mamane,

Pretty much on the dashboard/receipts/ page we load all modals on load; instead we want to only load them when the user clicks either preview button. If you don't have knowledge of HTMX or django views this may not be the best first feature, as it's pretty complex with HTMX. You can look at our other views if you want to give it a shot. image

on load you can see all images trying to be rendered, before we even preview them image

hussein-mamane commented 3 months ago

I know django but not htmx, I will look for another issue. thanks.

TreyWW commented 3 months ago

If you have discord you can join our server, we have quite a lot of features listed only on there. We can have better discussions about them too.

hussein-mamane commented 3 months ago

I'll be there