issues
search
TreyWW
/
MyFinances
MyFinances is a web application that can help you as an individual, or team, manage your finances!
https://docs.myfinances.cloud
GNU Affero General Public License v3.0
85
stars
121
forks
source link
Fixed ValueError issue
#380
Closed
Domejko
closed
1 month ago
Domejko
commented
1 month ago
Description
Changed empty strings
""
to
"0"
because
int("")
would cause an
ValueError
. If hours or price_per_hour field will be empty
0
will give a desired false in
if not
statements.
Checklist
[x] Ran the
Black Formatter
and
djLint-er
on any new code (checks will fail without)
[x] Made any changes or additions to the documentation
where required
[x] Changes generate no new warnings/errors
[x] New and existing
unit tests
pass locally with my changes
What type of PR is this?
🐛 Bug Fix
Added/updated tests?
🙅 no, because they aren't needed
Related PRs, Issues etc
Related Issue #
Closes #
Description
""
to"0"
becauseint("")
would cause anValueError
. If hours or price_per_hour field will be empty0
will give a desired false inif not
statements.Checklist
What type of PR is this?
Added/updated tests?
Related PRs, Issues etc