Query issue fix

[Domejko]

Description

Regarding #267

• Refactored CustomUserMiddleware to replace AuthenticationMiddleware
• Removed CustomUserMiddleware from backend/models.py and placed it in backend/middleware.py
• In settings/settings.py replaced "django.contrib.auth.middleware.AuthenticationMiddleware" with "backend.middleware.CustomUserMiddleware"

Checklist

• [x] Ran the Black Formatter and djLint-er on any new code (checks will fail without)
• [x] Made any changes or additions to the documentation where required
• [x] Changes generate no new warnings/errors
• [x] New and existing unit tests pass locally with my changes

What type of PR is this?

• 🐛 Bug Fix

Added/updated tests?

• 🙅 no, because they aren't needed

Related PRs, Issues etc

• Related Issue #
• Closes #267

[TreyWW]

Oh i've just seen what you mean, in our middleware we dont even call the additional fetch for profile. Maybe it's somewhere else. I'll check it out now, i could've swore it was here

[TreyWW]

Ah this is what I was thinking of https://github.com/TreyWW/MyFinances/blob/main/backend/models.py#L41

[Domejko]

Problem is that both AuthenticationMiddleware and CustomUserMiddleware where using query to fetch the user object. I removed AuthenticationMiddleware from MIDDLEWARE and adjusted CustomUserMiddleware so that it would replace it and populate request.user with our CustomUser instance.

With this changes we don't get double query issue and user profile is also accessible in request.user.

[TreyWW]

Amazing. Does this pass all tests still and everything visually work on the site? Just wondering if any Django packages use the middleware or if they will automatically move over to our new one

[Domejko]

Yes it was passing tests on my machine and on website everything work as intended. As for AuthenticationMiddleware I did check and it looks like it's not used anywhere else in Django.

I will fix that mypy error and will push that PR.

[TreyWW]

Thanks @Domejko, really appreciate the support recently!