search

TriAxis-Games / RealtimeMeshComponent

Unreal Engine 5 plugin component for rendering runtime generated content.
https://rmc.triaxis.games/
Other
1.53k stars 405 forks source link

UpdateSectionGroup fix #271

Closed CitizenCEO closed 6 months ago

CitizenCEO commented 7 months ago

UpdateSectionGroup has a problem which will empty all other buffers when supplementing incomplete stream set

Following edits in source code fixes these problems:

FILE: 
RealtimeMeshSectionGroup.cpp LINE 236

FROM:
if (!InStreams.Contains(StreamKey))

TO:
if (InStreams.Contains(StreamKey))

This removes only the streams that were supplemented in parameters Will this be reflected in the next update? I would love to do merge request but have no idea how to do that... Even tho I work as a gamedev 😳

Koderz commented 6 months ago

Hey @CitizenCEO

That is actually correct for that function as that function is supposed to replace all existing streams. I could make a separate function that could supplement the streams with the ones you're adding, but that function is SetAllStreams so by design it's supposed to remove any streams you aren't supplying, and update or create if necessary the ones you're supplying.

Hopefully that helps?

If I'm misunderstanding what you're trying to say feel free to reopen this issue.

Thanks -Chris