Open bartlettroscoe opened 7 years ago
This needs to be looked into soon due to the increased dependence on these <Package>Config.cmake
files with the work we are doing with ATDM.
It appears I didn't quite fix it. Making Common sub package ST doesn't fix the problem as tests could be turned off. May be making it REQUIRED will help ?
It appears I didn't quite fix it. Making Common sub package ST doesn't fix the problem as tests could be turned off. May be making it REQUIRED will help ?
Note sure at this point. Will need to dig in and investigate what is happening with this. I will need to look at the <Package>Config.cmake
files being produced by Trilinos for packages that have subpackages and see if I can see a pattern. I will need to do that before I can figure out how to add an automated test case to reproduce the problem so that I can fix this.
How urgent is this? For the case with SPARC and SEACAS, I just directly including the SEACAS subpackage's <Package>Config.cmake
files that SPARC was actually using and that worked just fine. (In fact, you might argue that users should directly point to the subpackages they are using to better manage their dependencies.)
It appears that there may be a defect in TriBITS where a parent package's
<Package>Config.cmake
file my not list the dependencies of its subpackages, even when those subpackages are enabled. I think noticed this when I was working on the SPARC prototype build system for TriBITS when trying to read in the SEACASConfig.cmake file (and it was empty) and it looks like the ShyLU developers may have hit this judging from the commit trilinos/Trilinos@ede8fe1a3e82c9437ca42c0ef55b31b98ce44779: