I noticed this as part of working on testing PR #479 with Trilinos as part of #299. This should have been addressed as part of PR #464.
Review Checklist
[x] Look over updated documentation in the files TribitsAddTest.cmake and TribitsAddAdvancedTest.cmake which is displayed for tribits_add_test() and tribits_add_advanced_test(). Look for typos, bad logic, etc.
[x] Just scan the updated tests. Hopefully their purpose and what they are checking is clear. (If it is not, then we need to add comments to the test in the files.)
If you find any obvious problems (and I already see a couple of them), please create a PR against 'master' to fix them.
TIME LIMIT: According to code review best practices, given this PR has about 200 lines of code, this review should not take any longer than 30 minutes (at a review rate of 400 LOC per hour).
@KyleFromKitware, if you have time, can you please do a post-merge review of this PR? See the "Review Checklist" above. This should not take more than 30 minutes.
See the commit log for commit https://github.com/TriBITSPub/TriBITS/commit/fd681d2823116a813e85f4a39478bc2750011b8e for details.
I noticed this as part of working on testing PR #479 with Trilinos as part of #299. This should have been addressed as part of PR #464.
Review Checklist
TribitsAddTest.cmake
andTribitsAddAdvancedTest.cmake
which is displayed fortribits_add_test()
andtribits_add_advanced_test()
. Look for typos, bad logic, etc.If you find any obvious problems (and I already see a couple of them), please create a PR against 'master' to fix them.
TIME LIMIT: According to code review best practices, given this PR has about 200 lines of code, this review should not take any longer than 30 minutes (at a review rate of 400 LOC per hour).