Closed bartlettroscoe closed 1 year ago
@KyleFromKitware, are you done with the review of this PR?
are you done with the review of this PR?
Yes. Please fix the typo I spotted in https://github.com/TriBITSPub/TriBITS/pull/527#discussion_r973330059.
Description
This PR almost exclusively involves the renaming of internal variables and macros/functions to make more explicit about what these are and to get ready for the final refactoring to combine logic for the handling of packages and TPLs (#63). This also changes the STDOUT for cmake that prints out the initial list of enabled/non-enabled packages and TPLs and the final list of enabled and non-enabled packages and TPLs. Therefore, this could break user code that is grepping for these lists in the STDOUT.
Notes to reviewers
git diff --word-diff-regex="[a-zA-Z0-9]+" <commit-sha1>
for the individual commits that actually change large amounts of code. That will show the renamings very clearly with nice color coding.*.rst
and*.md
files which are meant for humans to read.