Open bartlettroscoe opened 1 year ago
@rppawlo and @etphipp, can you please look above and add a thumbs up if those behaviors are consistent with what we have agreed to in https://github.com/trilinos/Trilinos/pull/11322#issuecomment-1334530762? If not, please comment on what should be fixed.
@rppawlo and @etphipp, now the question is, how urgent is this compared to #367? But this is something I might get help with from Kitware.
I can't speak to the urgency #367, but I think this is somewhat urgent just because we have a bunch of tests that aren't being run in serial builds.
Description
As described in https://github.com/trilinos/Trilinos/pull/11322#issuecomment-1334063481, the updated behavior of TriBITS is to not add a test in an non-MPI SERIAL build when the test has an explicit
NUM_MPI_PROCS N
forN > 1
. But test will never be added ifCOMM serial
is passed intotribits_add[_advanced]_test()
in these cases.This Issue is to update
tribits_add[_advanced]_test()
to address the case whereCOMM serial
andNUM_MPI_PROCS N
forN > 1
are passed in.Proposed solution
Many different proposed solutions are discussed in comments after https://github.com/trilinos/Trilinos/pull/11322#issuecomment-1333904958. What we arrived at is to implement the following:
Case 1:
NUM_MPI_PROCS N
forN > 1
but no explicitCOMM ...
argument passed in:N
procs (which is the current TriBITS behavior)Case 2:
NUM_MPI_PROCS N
forN > 1
with explicitCOMM serial mpi
passed in:N
procs and one with1
proc (currently just theN
proc test is added)1
proc will be added (currently no test is added)Case 3:
NUM_MPI_PROCS N
forN > 1
with explicitCOMM serial
(but notmpi
) passed in: