search

TriBITSPub / TriBITS

TriBITS: Tribal Build, Integrate, and Test System,
http://tribits.org
Other
36 stars 46 forks source link

Repalce usage of legacy vars <Package>_[LIB|TEST]_[REQUIRED|OPTIONAL]_DEP_[PACKAGES|TPLS] (#63) #546

Closed bartlettroscoe closed 1 year ago

bartlettroscoe commented 1 year ago

Description

The primary purpose of this PR is remove the setting and usage of the legacy vars <Package>_[LIB|TEST]_[REQUIRED|OPTIONAL]_DEP_[PACKAGES|TPLS] that treat external TPLs and internal Packages as separate entities and instead use the new vars:

It also replaces some of the loops over just internal packages and TPLs with the entire list of packages (and then switching on <Package>_PACKAGE_BUILD_STATUS).

This takes us one step closer to completing #63 and being able to allow packages to be defined internally or externally in a fluid way.

There are still some more refactoring needed to complete the initial use case driving #63 (Use Case 3: Configure/build pointing to a subset of already installed TriBITS packages in same repo).

Instructions for Reviewers

This PR involving large blocks of code around in the same file and between different files. But these simple movements of code (with no changes in that code) are done in their own commits. Therefore, the best way to review this PR is to review it commit-by-commit.

There were also some other small refactorings and updates that were done and these are isolated into their own commits.

bartlettroscoe commented 1 year ago

Hello @KyleFromKitware, this is a big PR (see above suggestions for how to do the review commit-by-commit). It would be great if you could review it before you go on vacation next week. But if you can't, I will just merge it and set it up for a post-merge review when you get back in Jan 2023.

bartlettroscoe commented 1 year ago

Hello @KyleFromKitware, can you please do a post-merge review of this PR once you get back and have some time?

bartlettroscoe commented 1 year ago

@KyleFromKitware, is this all of the feedback you have on this PR?

KyleFromKitware commented 1 year ago

This is it for the moment, but I'll have more time on Wednesday and Thursday if you'd like me to take another look after our biweekly meeting tomorrow.

bartlettroscoe commented 1 year ago

This is it for the moment, but I'll have more time on Wednesday and Thursday if you'd like me to take another look after our biweekly meeting tomorrow.

@KyleFromKitware, sure, this is a lot of code touched and refactored so it should take a couple of hours to go over all of it carefully.

For now I will just post a PR that addresses the comments above and then I can post another one after that to address any other comments.