search

TriBITSPub / TriBITS

TriBITS: Tribal Build, Integrate, and Test System,
http://tribits.org
Other
36 stars 46 forks source link

Make TPL-to-TPL dependencies optional (#557) #558

Closed bartlettroscoe closed 1 year ago

bartlettroscoe commented 1 year ago

Disabling the upstream TPL HDF5 was disabling the TPL Netcdf and that broke several customer's Trilinos configure scripts. The issue is, that we can't treat TPL-to-TPL dependencies as required for cases like this (see https://github.com/trilinos/Trilinos/issues/11426).

In the future, we may need to expand TPL intra-dependencies to support optional and required dependencies because there are cases where you would like the behavior of required dependencies for some TPL relationships.

bartlettroscoe commented 1 year ago

Hello @KyleFromKitware, can you please do a post-merge review of this PR when you get a chance?