search

TriBITSPub / TriBITS

TriBITS: Tribal Build, Integrate, and Test System,
http://tribits.org
Other
36 stars 46 forks source link

Update CMake min version from 3.17 to 3.23 (#411) #565

Closed bartlettroscoe closed 1 year ago

bartlettroscoe commented 1 year ago

Parent Issue:

Description

Addresses part of #411 and is part of:

See last commit for more details.

bartlettroscoe commented 1 year ago

FYI: The GHA builds shown here for this PR branch shows that this works with the code as of the large PR #560. Therefore, I will not rebase this one commit to be on top of the 'master' branch and deploy this.

NOTE: Any time you change the GHA builds, you have to manually change the set of required builds to pass a PR on the GitHub settings (which is a manual process).

bartlettroscoe commented 1 year ago

Hello @KyleFromKitware, here is another smaller PR to review. This needs to be reviewed and merged before the large PR #560 because I have already changed the setting of the branch protection for 'master' to require these updated GHA jobs for updated versions of CMake.

bartlettroscoe commented 1 year ago

@KyleFromKitware, can you please do a post-merge reivew?

Adrian-Diaz commented 1 year ago

Is 3.23 a strict requirement for the Trilinos CMake config to work now? some of the systems I work with still only go up to 3.22 unfortunately.

bartlettroscoe commented 1 year ago

Is 3.23 a strict requirement for the Trilinos CMake config to work now?

Yes

some of the systems I work with still only go up to 3.22 unfortunately.

Which systems, specifically?