search

TriBITSPub / TriBITS

TriBITS: Tribal Build, Integrate, and Test System,
http://tribits.org
Other
36 stars 47 forks source link

remove modern HDF5 version check #575

Closed ibaned closed 1 year ago

ibaned commented 1 year ago

HDF5 actually uses an equality function where major and minor numbers must match. This means the code was requiring 1.10 and 1.11 or higher would not work. It seems the best solution to just remove this check altogether since even the 1.10 version was a guess

bartlettroscoe commented 1 year ago

@ibaned, would it make sense to put in a version check for the version of HDF5 found in the file FindNetcdf.cmake before using "modern" mode?

ibaned commented 1 year ago

My feeling is that since this is all currently opt-in, it can be the user's responsibility to provide compatible versions of NetCDF and HDF5 and not TriBITS' responsibility to do any additional checking, but I support anything that doesn't prevent me from using newer HDF5 versions

bartlettroscoe commented 1 year ago

My feeling is that since this is all currently opt-in, it can be the user's responsibility to provide compatible versions of NetCDF and HDF5 and not TriBITS' responsibility to do any additional checking, but I support anything that doesn't prevent me from using newer HDF5 versions

Fair enough. In this transition stage of the CMake package ecosystem to modern CMake, things are going to be messy along the way. (Just hope we can get the part of the CMake ecosystem we care about updated to modern CMake before CMake gets replaced by Meson 😀)