Closed bartlettroscoe closed 10 months ago
Hello @KyleFromKitware, if you have some time, can you please review this PR? It is likely better to review it commit-by-commit than all-at-once.
@KyleFromKitware, I think this is ready to merge as it has resolved all of your comments. Can you approve the PR if it looks good to you?
Hello @KyleFromKitware, can you please do a post-merge review of the generated documentation at:
?
This refers to the raw and CMake build system under:
Addresses:
582
Description
This PR provides the changes to TriBITS and the TribitsExampleProject2 project to allow 100% raw CMake (with no TriBITS commands or functionality at all) to be used to define a TriBITS-compliant package. Such a TriBITS package should a a valid [TriBITS-compliant internal package] (https://tribitspub.github.io/TriBITS/users_guide/index.html#tribits-compliant-internal-packages) and produce a TriBITS-compliant external package.
Tasks
tribits_add_test()
in stand-alone raw CMake projecttribits/core/testing_support/
and modules that can be directly included without settingCMAKE_MODULE_PATH
?Update TriBITS to useNot needed for these use cases but will be needed if a TriBITS project is pulled into a larger CMake base project usingTRIBITS_PROJECT_NAME
,${TRIBITS_PROJECT_NAME}_SOURCE_DIR
and${TRIPTS_PROJECT_NAME}_BINARY_DIR
instead ofPROJECT_NAME
,PROJECT_SOURCE_DIR
andPROJECT_BINARY_DIR
, respectively, and make all tests pass (to support use cases like the Sierra prototype CMake build that is including a TriBITS project under a non-TriBITS project usingadd_subdirectory()
whereTRIBITS_PROJECT_NAME != CMAKE_PROJECT_NAME
orPROJECT_NAME
)add_subdirectory()
.