search

TriBITSPub / TriBITS

TriBITS: Tribal Build, Integrate, and Test System,
http://tribits.org
Other
36 stars 46 forks source link

Add git version info for parent commits (#597) #598

Closed bartlettroscoe closed 8 months ago

bartlettroscoe commented 9 months ago

WIP: This PR adds tests and functionality for adding git parent info for:

achauphan commented 8 months ago

Forced push for a rebase on dce52b6 which had a typo in the commit message and triggered the codespell.

achauphan commented 8 months ago

We're getting close! From the CDash results, looks like these outputs were not expected for the tests that check for multi-repo version outputs. Going to request a review anyways as I look into this next week.

Tagging because I cannot add @bartlettroscoe as he's owner and @sebrowne as he's not a collaborator

sebrowne commented 8 months ago

Looks fine to me

bartlettroscoe commented 8 months ago

@achauphan, I will add a more detailed review later but I think the issue with the failure of the tests:

Site Build Name Test Name Status Time Details Labels Build Time
ubuntu-latest pr-598_tribits_cmake-3.24.3_makefiles_python-3.8_g++-11_noninja TriBITS_CTestDriver_TribitsExMetaProj_clone_custom_branch_remote Failed 12s 750ms Completed (Failed)   2024-01-12T21:01:39 EST
ubuntu-latest pr-598_tribits_cmake-3.23.1_makefiles_python-3.8_g++-9 TriBITS_CTestDriver_TribitsExMetaProj_clone_custom_branch_remote Failed 11s 740ms Completed (Failed)   2024-01-12T21:01:41 EST
ubuntu-latest pr-598_tribits_cmake-3.25.2_makefiles_python-3.8_g++-11 TriBITS_CTestDriver_TribitsExMetaProj_clone_custom_branch_remote Failed 14s 440ms Completed (Failed)   2024-01-12T21:01:50 EST
ubuntu-latest pr-598_tribits_cmake-3.24.3_makefiles_python-3.8_g++-11_noninja TriBITS_CTestDriver_TribitsExMetaProj_clone_default_branch_remote Failed 15s 80ms Completed (Failed)   2024-01-12T21:01:39 EST
ubuntu-latest pr-598_tribits_cmake-3.23.1_makefiles_python-3.8_g++-9 TriBITS_CTestDriver_TribitsExMetaProj_clone_default_branch_remote Failed 13s 600ms Completed (Failed)   2024-01-12T21:01:41 EST
ubuntu-latest pr-598_tribits_cmake-3.25.2_makefiles_python-3.8_g++-11 TriBITS_CTestDriver_TribitsExMetaProj_clone_default_branch_remote Failed 17s 740ms Completed (Failed)   2024-01-12T21:01:50 EST

shown here. Not clear what the cause is for this but I think that, by default, we should not be printing parent info.

achauphan commented 8 months ago

@bartlettroscoe @sebrowne whenever ya'll have time, can ya'll give this another review?

bartlettroscoe commented 8 months ago

@achauphan, since it took me so long to get to this review, I can make the final changes and get this merged (and set up the snapshot to Trilinos PR). Or if you want to make the final change, I can review that and get it merged. Just let me know.

P.S. I could to document the TriBITS snaphsottting to Trilinos on the Trilinos wiki if you would like to give that a try.

achauphan commented 8 months ago

@achauphan, since it took me so long to get to this review, I can make the final changes and get this merged (and set up the snapshot to Trilinos PR). Or if you want to make the final change, I can review that and get it merged. Just let me know.

P.S. I could to document the TriBITS snaphsottting to Trilinos on the Trilinos wiki if you would like to give that a try.

@bartlettroscoe thanks for another round of reviews, this one was kinda fun! Yes, if you could, please go a head and make the final changes and get this snapshotted into Trilinos :)

I would love to go through learning the process of snapshotting this myself, but would like to try to use my time left for this sprint to try and finish up the python tool.

bartlettroscoe commented 8 months ago

Yes, if you could, please go a head and make the final changes and get this snapshotted into Trilinos :)

Doing that now ...

bartlettroscoe commented 8 months ago

@achauphan, I created the stacked PR:

against this PR for which should contain the final changes needed to merge this PR #598. (A stacked PR makes it easier to review a chuck of commits at one time. But I would still suggest reviewing the commits one-at-a-time.) If you have time to review that stacked PR, please let me know. Otherwise, I will merge that PR to this PR and move forward with the final merge and snapshotting to Trilinos.