search

TriBITSPub / TriBITS

TriBITS: Tribal Build, Integrate, and Test System,
http://tribits.org
Other
36 stars 47 forks source link

Should be final commits for Git version parent info PR #598 (#597) #601

Closed bartlettroscoe closed 6 months ago

bartlettroscoe commented 6 months ago

CC: @achauphan

This should be the remaining commits to address the issues in my latest review of PR:

given in https://github.com/TriBITSPub/TriBITS/pull/598#pullrequestreview-1839529322.

This is what is called a "Stacked PR".

bartlettroscoe commented 6 months ago

Would modifying the test tribits_add_advanced_test(CTestDriver_TribitsExMetaProj_clone_default_branch_remote) and enabling ${PROJECT_NAME}_SHOW_GIT_COMMIT_PARENTS = ON be a reasonable method of covering this?

@achauphan, that is not a bad idea. Let me try that locally and see what that looks like. (It looks likes those top commits are merge commits so we should see two parent comments.)

Update: I was able to update that test in commit 548a0b96f14393465179d50e1295dbd1a6b388bf and verify that it tests extra repos and that option.

bartlettroscoe commented 6 months ago

FYI: I pushed this branch to the main repo so that I could run the GHA testing on it and I manually fired off the GHA jobs and they completed and all passed as shown at:

So now I feel good about merging this PR.