search

TriForceX / MiyooCFW

Custom firmware source code and resources for BittBoy, PocketGo, PowKiddy V90-Q90-Q20 and third party handheld consoles
GNU General Public License v2.0
1.11k stars 112 forks source link

[FEATURE-REQ]: Add 1.6 scale and less sharpness to gambatte in retroarch #567

Open jeffbzrr opened 8 months ago

jeffbzrr commented 8 months ago

💡 Feature request

Hello everything is fine? Add 1.6 scale and less sharpness to gambatte in retroarch.

How can I contribute to this? What would be the way? I have some experience with code.

Motivation (behind your idea)

There is currently no such option in retroarch core, but it is available in gambatte outside of retroarch

salvacam commented 8 months ago

For what you are asking for, I think the best thing to do is to create a retroarch filter. You would have to create the filter and make a PR to the Retroarch repository https://github.com/libretro/RetroArch

For example, in this PR a new filter is added https://github.com/libretro/RetroArch/pull/13954

jeffbzrr commented 8 months ago

Yes, yes, that is the best way. I should have also posted it on retroarch but I only remembered about it later.

I started reading code. gambatte-dms has this upscaler and this is not in the retroarch because it is in the SDL part of gambatte-dms. I'm reading the PR you mentioned to understand how to make this filter. It would be an upscaler from 160x144 to 320x240.

The Upscale_240x160-320x240 of this PR is wonderful, really good. Much better than options outside of retroarch.

Some filters don't work on 8-bit cores, I don't understand that well yet.