TriHuynh00 / AC3R-Demo

Automatic Crash Constructor from Crash Report (A3CR) Demo of constructing simulations from crash reports
11 stars 6 forks source link

PR #14: Implementation for issue #32 #43

Closed harveyvn closed 3 years ago

harveyvn commented 3 years ago
alessiogambi commented 3 years ago

@harveyvn I struggle a bit to understand these two points:

Add a penalty to a fitness score when the damage components are not existed in the police report. Add a threshold to define whether a damage component deserves our revision.

Can you clarify them a little?

harveyvn commented 3 years ago

@harveyvn I struggle a bit to understand these two points:

Add a penalty to a fitness score when the damage components are not existed in the police report. Add a threshold to define whether a damage component deserves our revision.

Can you clarify them a little?

I noticed that the crash components sometime doesn't exist in the police report. @TriHuynh00 suggests that we might deduct a simulation's fitness score in such cases to make the fitness score become more relevant to the police report.

Regarding to a threshold, the damage value of crash components are sometime extremely small. In the previous AC3R, we didn't consider it as a crash component.

alessiogambi commented 3 years ago

I noticed that the crash components sometime doesn't exist in the police report. @TriHuynh00 suggests that we might deduct a simulation's fitness score in such cases to make the fitness score become more relevant to the police report.

So if the police report does not mention how cars were damaged any crash would work for us or better it does not matter in the fitness function. So your suggestion is to computer an optimal fitness value which is lower that the usual? Sounds good to me. So we probably have cases of different precision: no crashed component, only front/back or side, and very precise descriptions like the front left side.

I'm this case probably we should be able to count the number of conditions that we can match and give them a target score. Then we sum them up only if they are mentioned in the report. Nice

Regarding to a threshold, the damage value of crash components are sometime extremely small. In the previous AC3R, we didn't consider it as a crash component.

OK but what is the solution? A minim value on damage ti be considered a crash? Would it be possible to consider car's bounding boxes and say whether a crash happened?

harveyvn commented 3 years ago

I'm this case probably we should be able to count the number of conditions that we can match and give them a target score. Then we sum them up only if they are mentioned in the report. Nice

I updated cal_fitness to count the number of conditions that one crash scenario matches to a police report. After crashed simulation finishes, there are 2 special situations as below which I need your advices:

OK but what is the solution? A minim value on damage ti be considered a crash? Would it be possible to consider car's bounding boxes and say whether a crash happened?

We don't use this value to be considered a crash. At the moment, a value is 0.05 to indicate whether the component should be counted in the cal_fitness or not. I think about this factor because in the previous AC3R's summary, we use the symbol U to mention the case that we cannot measure the level of damage of one vehicle since it is really small. Syntax is given below:

Structure: [caseName]:1-[MatchValue]:2-[MatchValue] Example: Case0:1-PS:2-U MatchValue will be:

  1. P: Match a position in a report
  2. S: Match a side in a report
  3. PS: Match a position and a side
  4. U: Cannot measure due to the damage value is extremely small
alessiogambi commented 3 years ago

I am not entirely convinced by this approach to deduct point for unexpected damaged component. I am. In favor to penalize wrong simulations but if the police report is under specified any crash would do. Please put this on hold till the next meeting. Better to discuss it face to face

alessiogambi commented 3 years ago

Below the snapshots for todays meeting.

Screen Shot 2021-03-23 at 10 39 47 Screen Shot 2021-03-23 at 10 27 33 Screen Shot 2021-03-23 at 09 59 59