search

TriHuynh00 / AC3R-Demo

Automatic Crash Constructor from Crash Report (A3CR) Demo of constructing simulations from crash reports
11 stars 6 forks source link

PR #23: Implementation for issue #64 #67

Closed harveyvn closed 3 years ago

harveyvn commented 3 years ago

Provide fixes for trajectory issues in Case 1, 2 and 3.

Screencasts: Case 0 - 6 (except 3): https://www.dropbox.com/s/4bv60ur8b6m6uk0/C0-C6.mov?dl=0 Case 3: https://www.dropbox.com/s/i15twwxmjdt448u/C3.mov?dl=0

0 1 2 3 4 5 6

harveyvn commented 3 years ago

Hi Dr. @alessiogambi, due to the difference in the scale of horizontal and vertical axes in the chart, the length between points in Case 1, 2, and 3 looks different. I have rechecked, and all distances are about 5.

alessiogambi commented 3 years ago

Uhm... Can you check whether the option that sets the axis ratio to "equal" is activated?

harveyvn commented 3 years ago

Uhm... Can you check whether the option that sets the axis ratio to "equal" is activated?

I set the axis ratio to equal, and here is a result.

image

image

alessiogambi commented 3 years ago

Those look exactly as I expected. And I suggest we always use this configuration in our plots because in reality there's no point in representing space/distances using axis with different scales.

alessiogambi commented 3 years ago

LGTM. We can merge this