Open abrenoch opened 3 months ago
Could you make a PR? Then we will see if some tests fail.
@TriPSs
So I'm trying to make this work but am running into a typescript problem with that change:
Conversion of type '{ [x: string]: { is: DTO[keyof DTO]; }; }' to type 'Filter<DTO>' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
Type '{ [x: string]: { is: DTO[keyof DTO]; }; }' is not comparable to type 'FilterComparisons<DTO>'
Looking at the types for FilterComparisons
and FilterFieldComparison
, it appears that FilterFieldComparison
extends BooleanFieldComparisons
... But using the is
operator doesn't seem to be permitted.
Seems like this is the only issue with the change - any thoughts on why this might be the case?
Edit: Here is the branch I'm working with if it helps
@abrenoch thanks, can you already create the PR? Will take a look.
Describe the bug We discovered an issue when sorting by a field with
null
values while using thePagingStrategies.CURSOR
strategy. The issue manifests itself as no additional items loading beyond the first query, but upon further investigation it seems the query used to recover the 'cursor' item actually contains a small syntax problem (that doesn't cause an error - at least in MariaDB).Have you read the Contributing Guidelines?
yes
To Reproduce Using the following
QueryOptions
on a DTO:Steps to reproduce the behavior:
endCursor
to get the next page of data, no items are returned in the query:{ "data": { "getAssets": { "edges": [], "pageInfo": { "hasNextPage": false, "hasPreviousPage": true, "endCursor": null, "startCursor": null, "typename": "PageInfo" }, "typename": "AssetConnection", "totalCount": 247941 } } }
Appears to resolve the issue for mysql - but I'm not sure if this would be correct for other drivers or if some other methodology should be considered.