TriPSs / nestjs-query

Easy CRUD for GraphQL.
https://tripss.github.io/nestjs-query/
MIT License
164 stars 46 forks source link

Null sorting fix #271

Closed abrenoch closed 2 months ago

abrenoch commented 5 months ago

See https://github.com/TriPSs/nestjs-query/issues/270

nx-cloud[bot] commented 5 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a25a88284e91bcddd967b147906504367acc43a7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 5 targets - [`nx run-many --target=e2e --all`](https://cloud.nx.app/runs/lcogP2es9w?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=test --all`](https://cloud.nx.app/runs/Jp3FojNXb5?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --all`](https://cloud.nx.app/runs/23xkMLYIsf?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=lint --all`](https://cloud.nx.app/runs/2FVdaFrf15?utm_source=pull-request&utm_medium=comment) - [`nx run workspace:version`](https://cloud.nx.app/runs/d1swnvR2Wz?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

TriPSs commented 2 months ago

@abrenoch the linting errors now could be fixed by running the linter with --fix. (Bit weird that Nx no longer outputs it here in the CI)

abrenoch commented 2 months ago

Hey @TriPSs does your nx cloud run say what the lint errors are? I'm trying to work out what is failing, even pointed the nxCloudAccessToken to a workspace I can check, and I'm seeing these "Buildable libraries cannot import or export from non-buildable libraries" errors when running yarn nx run-many --target=lint --all (adding --fix didnt seem to help).

Could you provide some insight please? I have no idea what the issue here is.

TriPSs commented 2 months ago

@abrenoch reran the jobs and disabled that Nx does not output the logs here, bit weird that this was auto enabled.

abrenoch commented 2 months ago

Added a couple small changes the linter was complaining about - odd they were unrelated to the actual change I had made, but /shrug

TriPSs commented 2 months ago

Thanks for everything!