search

TriPed-Robot / trip_kinematics

Python package for inverse kinematic calculations of hybrid serial parallel robots
https://trip-kinematics.readthedocs.io/en/main/
MIT License
28 stars 5 forks source link

Static method #28

Closed TorbenMiller closed 3 years ago

TorbenMiller commented 3 years ago

Static methods should be called with the Class not the instance. This is not the cases in Robot.py at line 137. Python seems to tolerate this as tests show no error. Nonetheless this should be fixed

TorbenMiller commented 3 years ago

This function could be made private instead of static. It currently has no use in other parts of the code.

liquidcronos commented 3 years ago

solved in commit 67518156a6438dd46dd140ad408d2a3379d0d090