Triangle-Modeling-and-Analytics / TRMG2

The second generation of the Triangle Regional Model
https://triangle-modeling-and-analytics.github.io/TRMG2/
MIT License
11 stars 4 forks source link

Ramp Tagging #380

Open Flatiron87 opened 5 months ago

Flatiron87 commented 5 months ago

When ramps are tagged with the nearest HCMType in the Network Calculations, if ramps only connect to other new ramps, then a HCMType 'Freeway' is assigned in all cases. The script is written like this: image

Here is an example. Note that there are no freeway links connected or near these ramps. image

The script needs to be updated so that tagging can find the closest link, even if it is another ramp or other new link.

dkyleward commented 3 months ago

Tagging @lfhuntsinger

So this section of code is basically a simple trap for this particular edge case. I could flesh this out so that it walks the link network until it finds the nearest non-ramp link and then uses that facility type. However, the impact of this on the network is very small.

Given that, help me figure out where to prioritize this next time we meet.