search

Triangle-Modeling-and-Analytics / TRMG2

The second generation of the Triangle Regional Model
https://triangle-modeling-and-analytics.github.io/TRMG2/
MIT License
11 stars 4 forks source link

Error in mode share summary table #392

Closed Flatiron87 closed 1 month ago

Flatiron87 commented 3 months ago

The following table (overall_mode_shares_bytaz.bin) sums up the origin and destination trips for each TAZ including the od_veh_trips_PM_PKHR.mtx file (see .rsc snippet below). This .mtx should be excluded since it is already accounted for in the od_veh_trips_PM.mtx matrix. This results in too many origins and destinations by TAZ. The description should also note that these are the sum of the trip origins and trip destinations for each TAZ. Other summary tools should be reviewed to make sure this same over counitng is not occurring.

image

image

Flatiron87 commented 3 months ago

As a follow-up, this file and the overall_mode_shares_bycounty.bin include the productions at the external stations. Should these be excluded or if included, should a county name be assigned to them? Does 'auto' mode in this table include cv, sut and mut? image

dkyleward commented 1 month ago

First part fixed in commit fde5bd19ea37043edbe67b16413be3f54b9d91ae

For the second part, yes, they include CV/SUT/MUT. This is because what is being summarized is the entire highway assignment matrix. Also, if you want that null record to be replaced by "externals" let me know, but I'm going to mark this closed for now.