search

Triangle-Modeling-and-Analytics / TRMG2

The second generation of the Triangle Regional Model
https://triangle-modeling-and-analytics.github.io/TRMG2/
MIT License
11 stars 4 forks source link

Missing mode in scenario comparison tool #408

Open Si-Shi opened 2 months ago

Si-Shi commented 2 months ago

The scenario comparison tool will lose mode if that mode does not exist in the reference scenario. Currently the tool is doing a left join between reference table and new scenario table - so any modes that are not in the reference scenario will be lost.

dkyleward commented 1 month ago

@Si-Shi do you mind pointing me to the line number of the join you're referring to?

Si-Shi commented 1 month ago

Hi Kyle,

I realized I should provide more details in writing issues!

I'm referring to line 256 in the Diff Table macro (if you approve the new PR). For instance, if I set 2020 as the reference scenario and 2050 as the new scenario, the hb_trip_mode_shares comparison summary will only have modes existing in the 2020. New modes like cr and brt are missing in the comparison table. [image: image.png]

Thanks,

Si

On Thu, Aug 1, 2024 at 1:47 PM Kyle Ward @.***> wrote:

@Si-Shi https://github.com/Si-Shi do you mind pointing me to the line number of the join you're referring to?

— Reply to this email directly, view it on GitHub https://github.com/Triangle-Modeling-and-Analytics/TRMG2/issues/408#issuecomment-2263623270, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6SZSJX2CY5DHNZLG4QOSDZPJYCJAVCNFSM6AAAAABKXDPER2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRTGYZDGMRXGA . You are receiving this because you were mentioned.Message ID: @.***>