Triangle-Modeling-and-Analytics / TRMG2

The second generation of the Triangle Regional Model
https://triangle-modeling-and-analytics.github.io/TRMG2/
MIT License
11 stars 4 forks source link

Inconsistent identification of volume and VMT difference in links in the Scenario Comparison tool #426

Closed Flatiron87 closed 1 month ago

Flatiron87 commented 1 month ago

When the scenario comparison tool runs, it does not map all of the links with differences. For example, when comparing the base_2020 to the 2050 (v1.3.2), the Total_Flow_Daily Differences.map shows gaps and zero differences, however there are differences. In the first figure, the black numbers are from the road layer in the map: Roads.ID, RoadName, Total_Flow_Daily, Total_Flow_Daily_ref, Total_Flow_new, Total_Flow_Daily_Diff, abs_Total_Flow_Daily_Diff. The blue value is the 2020 total flow. Note that link 24937 is highlighted correctly. The adjacent link (163437 has a total 2050 flow of 29051 (same as adjacent link) and a base_2020 flow of 13,009 so it should have calcualted a difference (and show highlighted), however the difference is showing as 0. The VMT difference map is similar (see second figure)

image image

dkyleward commented 1 month ago

CC: @lfhuntsinger

I ran fresh base and 2055 scenarios using the dev branch version of the model. Everything looks good.

image

It may have been something we have fixed in the meantime, or it may be that the scenarios you are comparing aren't from the same version of the model (e.g. 2050 might have been run months ago while base is fresh).

Either way, the next release of the model will work as it should. Closing this issue as complete.

Flatiron87 commented 1 month ago

Ok. I'll check it when we get the 2055 data for V2. I tried it on the base_2020 and 2050 scenarios for v1.3.2. Mike

On Thu, Oct 17, 2024, 11:24 AM Kyle Ward @.***> wrote:

CC: @lfhuntsinger https://github.com/lfhuntsinger

I ran fresh base and 2055 scenarios using the dev branch version of the model. Everything looks good. image.png (view on web) https://github.com/user-attachments/assets/e186ed04-28af-4cbf-b6dd-217e129e0edc

It may have been something we have fixed in the meantime, or it may be that the scenarios you are comparing aren't from the same version of the model (e.g. 2050 might have been run months ago while base is fresh).

Either way, the next release of the model will work as it should. Closing this issue as complete.

— Reply to this email directly, view it on GitHub https://github.com/Triangle-Modeling-and-Analytics/TRMG2/issues/426#issuecomment-2419853887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ52VKO72ADFTZXOHEDGS6TZ37JDRAVCNFSM6AAAAABPZO2YFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJZHA2TGOBYG4 . You are receiving this because you authored the thread.Message ID: @.***>

lfhuntsinger commented 1 month ago

Thank you Mike and Kyle

On Fri, Oct 18, 2024 at 12:05 PM Mike @.***> wrote:

Ok. I'll check it when we get the 2055 data for V2. I tried it on the base_2020 and 2050 scenarios for v1.3.2. Mike

On Thu, Oct 17, 2024, 11:24 AM Kyle Ward @.***> wrote:

CC: @lfhuntsinger https://github.com/lfhuntsinger

I ran fresh base and 2055 scenarios using the dev branch version of the model. Everything looks good. image.png (view on web) < https://github.com/user-attachments/assets/e186ed04-28af-4cbf-b6dd-217e129e0edc>

It may have been something we have fixed in the meantime, or it may be that the scenarios you are comparing aren't from the same version of the model (e.g. 2050 might have been run months ago while base is fresh).

Either way, the next release of the model will work as it should. Closing this issue as complete.

— Reply to this email directly, view it on GitHub < https://github.com/Triangle-Modeling-and-Analytics/TRMG2/issues/426#issuecomment-2419853887>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AQ52VKO72ADFTZXOHEDGS6TZ37JDRAVCNFSM6AAAAABPZO2YFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJZHA2TGOBYG4>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Triangle-Modeling-and-Analytics/TRMG2/issues/426#issuecomment-2422799827, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP57ZQML6V2EEBKHJ5NJTOLZ4EWVVAVCNFSM6AAAAABPZO2YFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRSG44TSOBSG4 . You are receiving this because you were mentioned.Message ID: @.***>