Non Editable Input Text Fix

TrianguloY / URLCheck

Android app by TrianguloY: URLCheck

Other

969 stars 57 forks source link

Non Editable Input Text Fix #361

Closed mariachrisochoou closed 5 months ago

mariachrisochoou commented 5 months ago

This Pull Request corresponds to issue #100.

Goal: Declutter Screen for Improved Usability

Actions:

Added a TextView as a default state for displaying the URL.
Changed the visibility of the EditText to be initially hidden.
Updated the TextInputModule to reflect the appropriate changes.
Implemented an onClickListener: When the user clicks on the URL, it changes into an EditText to allow for editing.

Testing:

Tested the default state of the URL display.
Verified the visibility change of the EditText.
Confirmed the functionality of the onClickListener to ensure the URL changes to an EditText correctly.

Ideas for further improvement:

To add a switch in the input text module for the User to assign the default state (EditText or TextView).

github-actions[bot] commented 5 months ago

This PR builds correctly, here is the generated apk. This unsigned version can be installed alongside the original app and should only be used for testing the changes, not for daily usage.

Download testing apk

You must be logged in for the link to work. The link will expire at 2024-06-23T09:05:57Z.

_{This is an automatic comment created by a Github Action}

github-actions[bot] commented 5 months ago

This PR builds correctly, here is the generated apk. This unsigned version can be installed alongside the original app and should only be used for testing the changes, not for daily usage.

Download testing apk

You must be logged in for the link to work. The link will expire at 2024-06-24T17:58:57Z.

_{This is an automatic comment created by a Github Action}

mariachrisochoou commented 5 months ago

Thank you for your prompt and detailed review! I sincerely appreciate the time you've taken to provide feedback.

I've made the changes you suggested. I hope these adjustments address your concerns effectively.

Regarding the remaining issues, I regret to inform you that due to ongoing exam commitments, I won't be able to address them immediately. I aim to be able to complete these changes by the end of June. If this timeline doesn't align with your expectations, please let me know, and I'll do my best to accommodate.

Once again, thank you for your valuable feedback.

TrianguloY commented 5 months ago

That's enough, thanks! I'm merge it tomorrow if possible, and don't worry about the other changes. I've been testing it on my device and I want to tweak it a bit, so I'll just continue myself. This is perfect for a first simple iteration. Thanks again!