nahidtribedev
commented
3 years ago Note with Thanks
[http://www.tribetech.com.au/wp-content/uploads/2019/02/Tribetech_Logo_Small.png]http://www.tribetech.com.au/ Nahid Evan TribeDev Pty Ltd [http://www.tribetech.com.au/wp-content/uploads/2019/02/OfficePhone.png] [http://www.tribetech.com.au/wp-content/uploads/2019/02/MobilePhone.png] [http://www.tribetech.com.au/wp-content/uploads/2019/02/Email.png] @.**@.> [http://www.tribetech.com.au/wp-content/uploads/2019/02/Web.png]http://www.tribetech.com.au/ www.tribedev.com.auhttp://www.tribetech.com.au/ [http://www.tribetech.com.au/wp-content/uploads/2019/02/Map.png]https://goo.gl/maps/9k3ZqEbCy652 Level 8, 100 Walker St, North Sydney, NSW 2060 Australiahttps://goo.gl/maps/9k3ZqEbCy652
From: Nick Beaugeard @.> Sent: Friday, 28 May 2021 9:59 AM To: TribeDevAU/JuniorLearning @.> Cc: Nahid Evan @.>; Author @.> Subject: Re: [TribeDevAU/JuniorLearning] Blazor async (#6)
@nickbeau requested changes on this pull request.
See comments inline
+Name: @person.Salesperson
+
+
+
+
+
+Amount: @person.Amount
+
+
+
@.***{
+
+
+
+
- ///
This XML comment is hanging loose. Check out: https://blog.rsuter.com/best-practices-for-writing-xml-documentation-phrases-in-c/https://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fblog.rsuter.com%2Fbest-practices-for-writing-xml-documentation-phrases-in-c%2F&data=04%7C01%7Cnahid.evan%40tribedev.com.au%7C8cbfb77a64524aebc08408d9216b5e3b%7Cd15db61c9b7a472e8f75b38630bb554c%7C1%7C0%7C637577567295942404%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=24HLV7jqONJ0vGrt%2Fn3QIVBHvxMbP%2BOKjVib8TLZnsg%3D&reserved=0
- /// OnInitialized method used for OnDemand Print of Person
-
///
-
protected override void OnInitialized()
-
{
-
base.OnInitialized();
-
person = new IndexViewModel
-
{
-
Salesperson = "Alex",
-
Amount = 1000,
-
Locations = new List
-
{
-
new Location { id = 1, city = "London", postcode = 2192, Country = "England" }
-
}
-
};
Please make your code neater with correct indenting. It's super key that future people can read your code.,
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTribeDevAU%2FJuniorLearning%2Fpull%2F6%23pullrequestreview-670831262&data=04%7C01%7Cnahid.evan%40tribedev.com.au%7C8cbfb77a64524aebc08408d9216b5e3b%7Cd15db61c9b7a472e8f75b38630bb554c%7C1%7C0%7C637577567295952393%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=6u0%2BWaXIUqQh8EPzi4rwFthg%2F%2BC3QxeahOTnHvl0SFA%3D&reserved=0, or unsubscribehttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAT57JVI4PS6K6XEFBVBMQ6LTP3MDLANCNFSM45OMZ2OA&data=04%7C01%7Cnahid.evan%40tribedev.com.au%7C8cbfb77a64524aebc08408d9216b5e3b%7Cd15db61c9b7a472e8f75b38630bb554c%7C1%7C0%7C637577567295962399%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Eiwr7YE4L8TRSxsSb0mAGacgPx%2B0bWRb2hncqgOTCbE%3D&reserved=0.
async and await