Tribler / anydex-core

The Universal Decentralized Exchange
GNU Lesser General Public License v3.0
9 stars 6 forks source link

Add typing hints #60

Open devos50 opened 3 years ago

devos50 commented 3 years ago

Since the code of AnyDex is particularly error-prone (a single mistake can result in lost money), it would be helpful to add typing hints throughout the code base. #58 did add typing to some files, but there are many files left that require typing to be implemented.

Solomon1732 commented 3 years ago

If I open a PR to close this issue (either partially or wholly), should the commit history be one commit per (sub)module?

devos50 commented 3 years ago

I would suggest making separate commits and PRs to keep the number of changes small and maintainable 👍