Update Cloudomate to Python3 and add VPN support - Githubissues

Tribler / cloudomate

Unpermissioned Open Computer API

GNU Lesser General Public License v3.0

15 stars 16 forks source link

Update Cloudomate to Python3 and add VPN support #42

Closed Erackron closed 6 years ago

Erackron commented 6 years ago

The changes introduced by this PR:

Python 3 migration
Electrum dependency updated to the default python 3 variant
Mechanicalsoup instead of Mechanize
Added VPN support with AzireVPN as currently implemented provider
Added integration tests for all VPS providers (to test for breakage of purchase interaction)
Added a randomuser option to retrieve and use random user data from www.fakeaddressgenerator.com
Added VPSOutOfStockException to denote when a VPS is out of stock

devos50 commented 6 years ago

retest this please

devos50 commented 6 years ago

retest this please

devos50 commented 6 years ago

retest this please

devos50 commented 6 years ago

retest this please

tribler-ci commented 6 years ago

Can one of the admins verify this patch?

devos50 commented 6 years ago

retest this please

devos50 commented 6 years ago

retest this please

devos50 commented 6 years ago

retest this please

devos50 commented 6 years ago

retest this please

devos50 commented 6 years ago

retest this please

devos50 commented 6 years ago

retest this please

Erackron commented 6 years ago

@devos50 Your requested changes have been processed with a few exceptions:

sys.exit is still used (see comment reply)
namedtuple instances are still treated as classes in terms of capitalization (see comment reply)
The user_agent strings are still present in Hoster (not a change made by this PR and fixed in upcoming downstream PR)
'Getter' side-effect of the options method is also not a change introduced in this PR. and is also already addressed in the upcoming downstream PR

devos50 commented 6 years ago

Thanks for your contribution!