NEEDS DISCUSSION: Removed incoming message batching

Tribler / dispersy

The elastic database system. A database designed for P2P-like scenarios, where potentially millions of computers send database updates around.

http://www.tribler.org

84 stars 43 forks source link

Closed qstokkink closed 7 years ago

qstokkink commented 7 years ago

This PR removes incoming message batching (it DOES NOT remove the delayed message system).

In Tribler this affects the tunnel_community as it uses the cache argument for on_incoming_packets: https://github.com/Tribler/tribler/blob/devel/Tribler/community/tunnel/tunnel_community.py#L1041

As shown by the unit tests, there are cases where this approach causes a large increase in the amount of messages being sent.

triblerteam commented 7 years ago

No merging? Feel free to remove message batching at some point using some approach; assuming it does no harm.

qstokkink commented 7 years ago

@triblerteam This -and other wild optimizations- will be part of IPv8.