search

Tribler / dispersy

The elastic database system. A database designed for P2P-like scenarios, where potentially millions of computers send database updates around.
http://www.tribler.org
84 stars 43 forks source link

READY: Removed sleeps from tests #549

Closed qstokkink closed 7 years ago

qstokkink commented 7 years ago

This PR twistifies all sleep calls in the unit test code, EXCEPT in test_bootstrap (as this uses sleeps to control external processes).

I recommend reviewing test_double_signature in split diff mode, as this class had all of its Widows line endings (\r\n) replaced with Nix endings (\n).

NOTE: The multichain Tribler test will have to be updated to work with this PR.

qstokkink commented 7 years ago

@devos50 Hmm.. it seems that this twistified PR: https://jenkins.tribler.org/job/GH_Dispersy_PR_tests_linux/37/testReport/ is actually SLOWER across the board than the sleep() tests: https://jenkins.tribler.org/job/Test_dispersy_devel/lastCompletedBuild/testReport/

Do we really want this?

devos50 commented 7 years ago

Interesting, I didn't expect that!

At least the Dispersy tests are twistified now but if they becomes slower, we have to wait even longer.

qstokkink commented 7 years ago

@devos50 We may just have to swallow our pride on this one and keep the sleeps in.