Bootstrap server test does not work anymore after n-hop sync

Tribler / dispersy

The elastic database system. A database designed for P2P-like scenarios, where potentially millions of computers send database updates around.

http://www.tribler.org

87 stars 43 forks source link

Bootstrap server test does not work anymore after n-hop sync #554

Closed devos50 closed 7 years ago

devos50 commented 7 years ago

It seems that our bootstrap server test is broken after merge of n-hop sync (https://github.com/Tribler/dispersy/commit/1e2a70cf8a6dbf1d9e718df8679aee1479c063c2). See https://jenkins.tribler.org/job/Test_BootstrapServers/31812/ and https://jenkins.tribler.org/job/Test_BootstrapServers/31813/).

@qstokkink can you investigate this?

devos50 commented 7 years ago

I've also tested this on the bbq server and I confirm that the test doesn't work after the merge.

devos50 commented 7 years ago

@qstokkink also, my market experiment without the n-hop sync works as expected but with n-hop sync, no asks/bids are sent to other nodes :(

qstokkink commented 7 years ago

@devos50 Weird, it works on my machine^TM. I'll investigate this today.

EDIT: Oh wait, that test is on SKIP by default. EDIT2: It seems that backwards compatibility is still a thing, I'll refactor the n-hop-sync to its own Destination subclass. EDIT3: Your experiment not working anymore is a consequence of the peers no longer being able to communicate with the bootstrap servers. EDIT4: Thankfully, the fix for this is rather small.