search

Tribler / py-ipv8

Python implementation of Tribler's IPv8 p2p-networking layer
GNU Lesser General Public License v3.0
229 stars 47 forks source link

Convert GitHub release script to be fully local #1298

Closed qstokkink closed 2 months ago

qstokkink commented 2 months ago

Our main method to increment versions and to create release messages from the current head is github_increment_version.py. Because of the changes in GitHub token management, this script does not work as intended anymore.

We should find a way to convert the functionality of the script to GitHub Actions.

qstokkink commented 2 months ago

Having looked into the various ways to port the current script, I think there is simply no way around the personal access tokens. This is incredibly annoying and something I want to avoid like the plague.

I think the only sensible way to port this script is to change it and make it fully local.

We can still make the changes to the version numbers locally and calculate the changes by pulling in the upstream branch from a fork. However, opening the PR and auto-labeling it is then no longer possible. I think this is a relatively small sacrifice.

qstokkink commented 2 months ago

As a Hail Mary, we can try to use PyGitHub's Auth.Login before changing anything. The chances of this magically suddenly working are slim but this would avoid a lot of work.

EDIT: Tried it, doesn't work.