search

Tribler / tribler-utils

Repository for scripts and utilities for tribler
0 stars 4 forks source link

Port to python 3 since python 2 support is soon dropped #1

Closed Solomon1732 closed 4 years ago

Solomon1732 commented 4 years ago

As discussed with @qstokkink in Tribler/tribler#5029, the python 2 support is dropped in January 1st, 2020 (two days at the time of writing), therefor imo (edit: and theirs "As Python 2 support will formally be dropped in two days (!), I think it is safe to port it fully to Python 3") it is safe to port the repo (currently a relatively simple matter) to python 3.

devos50 commented 4 years ago

Hmm, there's not really much in this repository hehe. You want to take on the task to port the existing script, plus the ones linked in the Tribler issue to Python 3?

Solomon1732 commented 4 years ago

Sure, why not, lol. The bash script stay as bash, right? This is only about the python scripts?

devos50 commented 4 years ago

Yeah this should only apply to Python scripts, unless some bash script is explicitly using the Python 2 interpreter 👍

Solomon1732 commented 4 years ago

Where's the location of the scripts? Edit: Are all the scripts in the gist in Tribler/tribler#5029, or are there more elsewhere?

devos50 commented 4 years ago

The script for our spelling checker PR job is here. The script that checks if the PR adds new imports, is here.

It would be nice if these scripts can be moved to our utils repository, and be converted to Python 3 👍

Solomon1732 commented 4 years ago

Sorry about that. Will get on it.