Upgrade VC2008 runtime for Tribler 32-bit

[xevidencex]

Please, don't populate C: with dlls & data files for framework, c: is not a place to install software or framework data. it's a place that should remain clean & dangerous for not being mied up with elementary os files.

[qstokkink]

Thanks for your feedback: you should find that Tribler is much cleaner in the next release (Tribler 7.0).

[xevidencex]

after rc4?

one mpore thing would be good: -avoid that dos window on startup & its very very slow to start

On Wed, Nov 29, 2017 at 9:38 AM, Quinten Stokkink notifications@github.com wrote:

Thanks for your feedback: you should find that Tribler is much cleaner in the next release (Tribler 7.0).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Tribler/tribler/issues/3259#issuecomment-347789804, or mute the thread https://github.com/notifications/unsubscribe-auth/AZgywqu6UwSYKPkhVECfZlVlSvPxC00Qks5s7RgigaJpZM4QpDFa .

[qstokkink]

@xevidencex The dos window will be gone when 7.0 is officially released.

Does rc4 still give you dll files on your C:\ drive if you specified a different installation location in the installer? In that case, please tell us which files you found and I will reopen this issue.

[xevidencex]

Well, you've omitted to list the 32bits version of rc4 on tribler.org, but i've found it by changing the url of the 64bits version to "86" -> https://github.com/Tribler/tribler/releases/download/v7.0.0-rc4/Tribler_7.0.0-rc4_x86.exe

I'm not on 64 bit platform & won't move from 32 bits. but just to let you know, if i install the 64bits version (that i can't use nor open): https://github.com/Tribler/tribler/releases/download/v7.0.0-rc4/Tribler_7.0.0-rc4_x64.exe

No files are installed in c:

But the issue is persistent in the 32 bits version, & it saves the following files on c:, when they have nothing to do in the hard drive's root:

eula.1028.txt eula.1031.txt eula.1033.txt eula.1036.txt eula.1040.txt eula.1041.txt eula.1042.txt eula.2052.txt eula.3082.txt globdata.ini install.exe install.ini install.res.1028.dll install.res.1031.dll install.res.1033.dll install.res.1036.dll install.res.1040.dll install.res.1041.dll install.res.1042.dll install.res.2052.dll install.res.3082.dll vcredist.bmp VC_RED.cab VC_RED.MSI

Another downside, it's very very slow to start..

& one more thing:

I don't use vlc, the interface is non skinable & extremely old & ugly, not even mentioning the fact that "potplayer" beats vlc in terms of videotype decoding, so IF vlc is used as a plugin to display videos inside tribler's window, as a plugin, i understand the use of it. otherwise, if tribler only "calls" the vlc executable that independently opens itself outside of the tribler's inteface, Then..

A choise to not install vlc should be provided during setup, cause i'd prefer using potplayer by far.

thanks.

On Thu, Dec 14, 2017 at 8:44 AM, Quinten Stokkink notifications@github.com wrote:

@xevidencex https://github.com/xevidencex The dos window will be gone when 7.0 is officially released.

Does rc4 still give you dll files on your C:\ drive if you specified a different installation location in the installer? In that case, please tell us which files you found and I will reopen this issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Tribler/tribler/issues/3259#issuecomment-351632992, or mute the thread https://github.com/notifications/unsubscribe-auth/AZgywi1Du2oSLDZOAIgyVrK46d21-fRcks5tANHngaJpZM4QpDFa .

[qstokkink]

@xevidencex thanks for listing those files, we'll have a look.

Also, VLC is indeed used as a plug-in.

[devos50]

This seems to be related to the VC2008 redistributable: https://blogs.technet.microsoft.com/ucspotting/2009/02/21/what-are-those-pesky-files-in-my-root-folder/.

We already dropped support for VC2008 on 64 bit if I remember correctly. I doubt that it's our responsibility to fix this issue since it's related to the installer of a dependency.

[xevidencex]

then you should drop support for 32bit too. i probably already have the required files anyways.

On Fri, Dec 15, 2017 at 3:09 PM, Martijn de Vos notifications@github.com wrote:

This seems to be related to the VC2008 redistributable: https://blogs.technet.microsoft.com/ucspotting/2009/ 02/21/what-are-those-pesky-files-in-my-root-folder/.

We already dropped support for VC2008 on 64 bit if I remember correctly. I doubt that it's our responsibility to fix this issue since it's related to the installer of a dependency.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Tribler/tribler/issues/3259#issuecomment-352014517, or mute the thread https://github.com/notifications/unsubscribe-auth/AZgywvofSD5TEwpB_8w7iB0FXMFMQN_eks5tAn2vgaJpZM4QpDFa .

[xevidencex]

vc2008' support..

On Fri, Dec 15, 2017 at 3:26 PM, rob ukrainianconsular@gmail.com wrote:

then you should drop support for 32bit too. i probably already have the required files anyways.

On Fri, Dec 15, 2017 at 3:09 PM, Martijn de Vos notifications@github.com wrote:

This seems to be related to the VC2008 redistributable: https://blogs.technet.microsoft.com/ucspotting/2009/02/21/ what-are-those-pesky-files-in-my-root-folder/.

We already dropped support for VC2008 on 64 bit if I remember correctly. I doubt that it's our responsibility to fix this issue since it's related to the installer of a dependency.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Tribler/tribler/issues/3259#issuecomment-352014517, or mute the thread https://github.com/notifications/unsubscribe-auth/AZgywvofSD5TEwpB_8w7iB0FXMFMQN_eks5tAn2vgaJpZM4QpDFa .

[devos50]

@xevidencex The problem is that we need to bundle VC2008 since Python on 32-bit is compiled with that specific runtime.

[xevidencex]

i don't know what to tell you, i'm not a coder.

On Fri, Dec 15, 2017 at 3:37 PM, Martijn de Vos notifications@github.com wrote:

@xevidencex https://github.com/xevidencex The problem is that we need to bundle VC2008 since Python on 32-bit is compiled with that specific runtime.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Tribler/tribler/issues/3259#issuecomment-352021106, or mute the thread https://github.com/notifications/unsubscribe-auth/AZgywo2hSpntzCtBzf1tKaDgZUdQKI4hks5tAoQ4gaJpZM4QpDFa .

[devos50]

@qstokkink @xoriole any comments on this one?

[qstokkink]

@devos50 we were thinking of postponing the fix for this until after 7.0, as this only affects the x86 build and it will take quite a bit of effort.

[devos50]

@qstokkink I definitely agree. We should get rid of the VC2008 runtime of the 32-bit version (or even drop 32 bit at all?) but after the 7.0 release.

[xevidencex]

Please confirm me if 32 bits versions are to damn in 2017 & avoided in future releases, or even on 7.0, so i don't have to keep useless subscriptions & will be compelled to search for another client.

ty.

[devos50]

@xevidencex we will support a Tribler 32-bit client for the upcoming 7.0 release and make sure that it works as expected.

[xevidencex]

yes but needing anonimity, will it be dropped at 7.1 ?

[xevidencex]

& if i ever call it fjezfhrezhfe.exe for example.. will it ever create issues between dependencies & the main executable ? would the program function improperly ?

[devos50]

This issue will finally be addressed once we completed the migration of our infrastructure to Python 3.

[synctext]

Consider using this installer: https://github.com/jrsoftware/issrc (suggested by @devos50) The whole Python3, VC2008 runtime and 32-bit world will be different. Can it support all of our needs? NSIS installer scripts are ancient, but at least they work! Inno Setup is a free installer for Windows programs. First introduced in 1997, Inno Setup today rivals and even surpasses many commercial installers in feature set and stability.

[xoriole]

Seems to have support for everything we need but should check it out in more detail before we switch. The documentation seems pretty good: http://www.jrsoftware.org/ishelp/

[xoriole]

With this PR https://github.com/Tribler/tribler/pull/4917 merged, we no longer depend on VC2008 so I consider this issue to be resolved.