Tribler / tribler

Privacy enhanced BitTorrent client with P2P content discovery
https://www.tribler.org
GNU General Public License v3.0
4.78k stars 443 forks source link

Future proof Windows builder #4921

Closed xoriole closed 2 weeks ago

xoriole commented 4 years ago

Consider using this installer: https://github.com/jrsoftware/issrc (suggested by @devos50) The whole Python3, VC2008 runtime and 32-bit world will be different. Can it support all of our needs? NSIS installer scripts are ancient, but at least they work! Inno Setup is a free installer for Windows programs. First introduced in 1997, Inno Setup today rivals and even surpasses many commercial installers in feature set and stability.

Originally posted by @synctext in https://github.com/Tribler/tribler/issues/3259#issuecomment-538905073

ichorid commented 4 years ago

For reference, the list of installation software.

Basically, there are only three open-source alternatives:

@xoriole , what advantages does InnoSetup offer over our current installer? What kind of problems it would solve?

ichorid commented 4 years ago

BTW, it would be really cool if we will push Tribler to Windows Store, to increase reach.

Solomon1732 commented 4 years ago

Pushing Tribler to Windows Store would make it convenience for me as a user. Due not, however, that due to US laws regarding exporting and importing certain classes of software it might limit Tribler's capabilities in the Store version. I would look into it deeper (I'm not verse in US legalese). I know it limits VLC's capabilities somewhat in the Store version because of this.

qstokkink commented 2 weeks ago

I think the discussion in this issue has now completed: we've investigated other software but we ended up with NSIS again anyway.