Replace PR "Print statements checker" with Flake-8 plugin

Tribler / tribler

Privacy enhanced BitTorrent client with P2P content discovery

https://www.tribler.org

GNU General Public License v3.0

4.8k stars 444 forks source link

Replace PR "Print statements checker" with Flake-8 plugin #5749

Closed qstokkink closed 3 years ago

qstokkink commented 3 years ago

We can obsolete the "Print statements checker" check on PRs (which was essential at the time, as neither pylint nor flake8 detect this in Python 3.x) with the https://pypi.org/project/flake8-print/ plugin.

This change would make print statement detection simply another check in the Flake 8 report.

Required changes:

Install the flake8-print pip package on bbq.
Enable the T001, T002, T003, T004 errors in the PR Flake 8 Jenkins job.

qstokkink commented 3 years ago

I'll hook this in.

qstokkink commented 3 years ago

The flake8-print Flake8 plugin has been added to bbq.
The PR_prints_check on Jenkins has been disabled (note: not removed).

If we don't experience any problems in the coming month or so we can probably completely remove the PR_prints_check permanently. I'll keep this issue open until that has happened.

ichorid commented 3 years ago

Also, try running pyupgrade through pre-commit on the whole codebase. Fun stuff!

qstokkink commented 3 years ago

Oops, forgot to close this. This has been done long ago.