search

Tribler / tribler

Privacy enhanced BitTorrent client with P2P content discovery
https://www.tribler.org
GNU General Public License v3.0
4.75k stars 445 forks source link

Update python version to `3.9` #7869

Open drew2a opened 5 months ago

drew2a commented 5 months ago

To complete the task, we should:

Ref:

xoriole commented 5 months ago

I have opted to use pyenv for setting up the python environment and updated the Jenkins script to use the correct python using pyenv local setup. So far, macOS and Linux builders are updated and the build seems to work too. But, Windows installation seems a bit challenging.

drew2a commented 5 months ago

For Windows, you might consider using Chocolatey as it may simplify things: Python 3.9 on Chocolatey.

xoriole commented 5 months ago

The reason why Python3.9 was not working on our builders is because Python3.9 is not supported on Win7. Therefore, the windows builders need to be upgraded. This will likely affect some users using Win7 still.

I'll upgrade the builders on Win10 machines.

Ref: https://bugs.python.org/issue41412

xoriole commented 5 months ago

Priority for upgrading the builders is put on hold until the existing bugs are fixed. I'm unassigning myself till it becomes a priority again.

drew2a commented 5 months ago

@xoriole, "until the existing bugs are fixed" does sound a bit like "never"...

It seems like I should revert the changes I made to GitHub Actions because now it's possible that one of the developers will use a feature from Python 3.9, which will pass all the tests in a PR as they operate with Python 3.9. However, when we try to build the next release (for example, 7.14), we might encounter these incompatibilities since the builders use Python 3.8.

drew2a commented 4 months ago

@xoriole the issue you mentioned is fixed:

xoriole commented 2 months ago

Update on this ticket: Windows 64bit builder machine is upgraded to support Python3.9. This was used to build the TriblerExperimental release (win64) yesterday.

A few notes: