Closed kozlovsky closed 3 months ago
Currently, GUI tests GitHub action refuses to work due to the following error:
These files don't exist: cached-bin/libsodium-1.0.18/libsodium.dll Run C:\msys64\usr\bin\wget.exe -q https://download.libsodium.org/libsodium/releases/libsodium-1.0.18-msvc.zip C:\msys64\usr\bin\wget.exe -q https://download.libsodium.org/libsodium/releases/libsodium-1.0.18-msvc.zip 7z x libsodium-1.0.18-msvc.zip dir %RELEASE_FOLDER% /ad /b /o-n > latest_release_file set /p latest_release= < latest_release_file echo Latest release: %latest_release% if not exist "cached-bin\libsodium-1.0.18" mkdir "cached-bin\libsodium-1.0.18" copy %RELEASE_FOLDER%\%latest_release%\dynamic\libsodium.dll .\cached-bin\libsodium-1.0.18\libsodium.dll shell: C:\Windows\system32\cmd.EXE /D /E:ON /V:OFF /S /C "CALL "{0}"" env: PYTEST_SENTRY_DSN: *** pythonLocation: C:\hostedtoolcache\windows\Python\3.8.10\x64 PKG_CONFIG_PATH: C:\hostedtoolcache\windows\Python\3.8.10\x64/lib/pkgconfig Python_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.8.10\x64 Python2_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.8.10\x64 Python3_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.8.10\x64 VIRTUAL_ENV: C:\Users\runneradmin\.virtualenvs\.venv RELEASE_FOLDER: .\libsodium\x64\Release 7-Zip 23.01 (x64) : Copyright (c) 1999-2023 Igor Pavlov : 2023-06-20 Scanning the drive for archives: ERROR: The system cannot find the file specified. libsodium-1.0.18-msvc.zip
Examples:
It looks like wget has some problems with certificates that prevent downloading the libsodium library.
wget
libsodium
This PR fixes the problem by replacing the wget call with the curl call. Windows dependencies build successfully with this fix.
curl
wget is linked to OpenSSL whereas curl is linked to the NSS cryptographic libraries, and this can explain the difference: https://serverfault.com/questions/922222/why-does-curl-work-with-a-specific-https-site-but-wget-has-problems-with-certif
Currently, GUI tests GitHub action refuses to work due to the following error:
Examples:
It looks like
wget
has some problems with certificates that prevent downloading thelibsodium
library.This PR fixes the problem by replacing the
wget
call with thecurl
call. Windows dependencies build successfully with this fix.wget
is linked to OpenSSL whereascurl
is linked to the NSS cryptographic libraries, and this can explain the difference: https://serverfault.com/questions/922222/why-does-curl-work-with-a-specific-https-site-but-wget-has-problems-with-certif