Tribler / tribler

Privacy enhanced BitTorrent client with P2P content discovery
https://www.tribler.org
GNU General Public License v3.0
4.74k stars 445 forks source link

Build windows binary using Cx_Freeze #7936

Closed xoriole closed 3 months ago

xoriole commented 3 months ago

This PR aims to transition from PyInstaller to Cx_Freeze for generating Windows binaries. The motivation for this change is detailed here.

Although Cx_Freeze supports MSI installer generation (refer to the build.py documentation in the PR), this feature is not utilized. Instead, the existing NSIS-based installation process is maintained, with the switch only affecting the executable creation, previously managed by PyInstaller.

It's important to note that this PR exclusively alters the Windows build process. For Linux and MacOS, PyInstaller remains the tool of choice for binary creation. This decision stems from the absence of malware misidentification issues and the significantly smaller binary size produced by PyInstaller compared to Cx_Freeze on these platforms, prompting no changes there for the time being.