Tribler / tribler

Privacy enhanced BitTorrent client with P2P content discovery
https://www.tribler.org
GNU General Public License v3.0
4.73k stars 445 forks source link

Refactor RESTManager and add config.write when port changes #8022

Open heldersepu opened 1 month ago

heldersepu commented 1 month ago

With this change the http_port is updated as soon as it changes fixes #8007

github-actions[bot] commented 1 month ago

Hi @heldersepu, thank you for contributing to Tribler! 🚀

This PR was created by an outside collaborator, so some checks were not run for security reasons. To trigger the full set of checks, any member of the Tribler team can add the label PR: safe to check to the current PR.

heldersepu commented 1 month ago

@xoriole We debated that in the issue: https://github.com/Tribler/tribler/issues/8007#issuecomment-2100938488

in a nutshell: