Tribler / trustchain-android

An example android app for using trustchain
GNU Lesser General Public License v3.0
3 stars 2 forks source link

Offline block signing #60

Closed jonathanraes closed 6 years ago

jonathanraes commented 6 years ago

Includes a checkbox in Peersummayactivity that when checked used the send- and receive offline activities to transfer blocks instead of the network

codecov-io commented 6 years ago

Codecov Report

Merging #60 into develop will decrease coverage by 0.04%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop     #60      +/-   ##
==========================================
- Coverage     1.01%   0.96%   -0.05%     
==========================================
  Files           66      70       +4     
  Lines         7206    7568     +362     
  Branches      1093    1130      +37     
==========================================
  Hits            73      73              
- Misses        7128    7490     +362     
  Partials         5       5
jonathanraes commented 6 years ago

Made room for the error and implemented switch to receive activity automatically. For the first point, assuming you mean the ConnectionsOverview, Im unsure how to tackle a menu item for sending offline as creating a block proposal requires knowing the destinations public key, so you need to select a peer first. If you did mean the peer overview, then the menu item would just perform the exact action as the send button

jonathanraes commented 6 years ago

I screwed up, created the return button late last night but my phone was empty so I didnt really test it... I think this branch is finally ready for merging now though

wkmeijer commented 6 years ago

Hmm maybe it's a bit weird that the overview connections activity gets restarted on return though. Is there an easy way to just finish all activities except the overviewconnectionsactivity?

Edit: i.addFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP); Was also needed, now it doesn't restart. (see android developer reference) Can be merged IMO.