search

Tribler / trustchain-superapp

Kotlin implementation of Trustchain and IPv8 with rich networking: multihoming of local Bluetooth+4G, decentral social networking, UDP hole punching, etc.
GNU General Public License v3.0
80 stars 63 forks source link

Eurotoken II - Trust score & unverified transfers #113

Closed leondeklerk closed 2 years ago

leondeklerk commented 2 years ago

Stale branch of Euro ii team from spring 2022 class of Blockchain Engineering course. This contribution directly conflicts with the merged changes by team "Euro iii".

Adds unverified transfers, implementation on trust scores. Central gateway interaction still works.

InvictusRMC commented 2 years ago

Hi team please ensure your code passed our CI.

InvictusRMC commented 2 years ago

It has been over a week and your code is still not passing the CI. Please ensure your code is working before marking a PR as ready for review.

leondeklerk commented 2 years ago

@InvictusRMC we've fixed the CI issues. Please also keep in mind that this PR is going to be merged into a separate branch, mainly just as a way to preserve our work as it cannot go into the main branch.

devos50 commented 2 years ago

it cannot go into the main branch.

Why can't it go in the main branch?

leondeklerk commented 2 years ago

@devos50 this can't be merged with main as it directly conflicts with the work of Eurotoken III and we decided with @synctext to put our contribution on a separate branch to preserve the work in this repository.

leondeklerk commented 2 years ago

As for the failing CI, that seems to be an issue with https://raw.githubusercontent.com/blockchain/api-v1-client-java/mvn-repo/ not existing (anymore?) Which is not related to any of our changes.

devos50 commented 2 years ago

Looks like their entire repository got removed. Seems to be the risk of relying on third-party software...

We'll look into it.